Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(58)

Issue 111010043: Application Default Credentials: Fix precendence bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by Anthony Moore
Modified:
12 years, 3 months ago
Reviewers:
wonderfly, Orest
Base URL:
https://code.google.com/p/google-api-java-client/
Visibility:
Public.

Description

Application Default Credentials: Fix precendence bug

Patch Set 1 #

Patch Set 2 : Removed .classpath file #

Patch Set 3 : Move check to before path calculation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -16 lines) Patch
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProvider.java View 1 2 1 chunk +18 lines, -16 lines 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProviderTest.java View 1 chunk +71 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Anthony Moore
12 years, 3 months ago (2014-07-09 23:03:10 UTC) #1
Anthony Moore
Corrected some minor issues.
12 years, 3 months ago (2014-07-09 23:10:00 UTC) #2
wonderfly
On 2014/07/09 23:10:00, Anthony Moore wrote: > Corrected some minor issues. LGTM
12 years, 3 months ago (2014-07-09 23:31:41 UTC) #3
Orest
12 years, 3 months ago (2014-07-09 23:41:00 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b