Move getCertificateTrustStore() back to GoogleUtils.java.

Move getCertificateTrustStore() back to GoogleUtils.java.

[Anthony Moore, 2014-07-09 22:38:32]

Changes to the Java files look good, but it seems like a lot of unrelated config
stuff got included accidentally.

https://codereview.appspot.com/111000043/diff/1/google-api-client-android/.cl...
File google-api-client-android/.classpath (right):

https://codereview.appspot.com/111000043/diff/1/google-api-client-android/.cl...
google-api-client-android/.classpath:3: <classpathentry kind="src"
path="src/main/java" including="**/*.java"/>
Looks like it should not be in the checkin.

https://codereview.appspot.com/111000043/diff/1/google-api-client-android/.pr...
File google-api-client-android/.project (right):

https://codereview.appspot.com/111000043/diff/1/google-api-client-android/.pr...
google-api-client-android/.project:4: <comment>Sonatype helps open source
projects to set up Maven repositories on https://oss.sonatype.org/.
NO_M2ECLIPSE_SUPPORT: Project files created with the maven-eclipse-plugin are
not supported in M2Eclipse.</comment>
Looks like it should not be in the checkin.

https://codereview.appspot.com/111000043/diff/1/google-api-client-appengine/....
File google-api-client-appengine/.settings/org.eclipse.jdt.core.prefs (right):

https://codereview.appspot.com/111000043/diff/1/google-api-client-appengine/....
google-api-client-appengine/.settings/org.eclipse.jdt.core.prefs:2:
org.eclipse.jdt.core.formatter.insert_space_before_comma_in_for_inits=do not
insert
Looks like it should not be in the checkin.

[wonderfly, 2014-07-09 22:54:05]

On 2014/07/09 22:38:32, Anthony Moore wrote:
> Changes to the Java files look good, but it seems like a lot of unrelated
config
> stuff got included accidentally.
> 
>
https://codereview.appspot.com/111000043/diff/1/google-api-client-android/.cl...
> File google-api-client-android/.classpath (right):
> 
>
https://codereview.appspot.com/111000043/diff/1/google-api-client-android/.cl...
> google-api-client-android/.classpath:3: <classpathentry kind="src"
> path="src/main/java" including="**/*.java"/>
> Looks like it should not be in the checkin.
> 
>
https://codereview.appspot.com/111000043/diff/1/google-api-client-android/.pr...
> File google-api-client-android/.project (right):
> 
>
https://codereview.appspot.com/111000043/diff/1/google-api-client-android/.pr...
> google-api-client-android/.project:4: <comment>Sonatype helps open source
> projects to set up Maven repositories on https://oss.sonatype.org/.
> NO_M2ECLIPSE_SUPPORT: Project files created with the maven-eclipse-plugin are
> not supported in M2Eclipse.</comment>
> Looks like it should not be in the checkin.
> 
>
https://codereview.appspot.com/111000043/diff/1/google-api-client-appengine/....
> File google-api-client-appengine/.settings/org.eclipse.jdt.core.prefs (right):
> 
>
https://codereview.appspot.com/111000043/diff/1/google-api-client-appengine/....
> google-api-client-appengine/.settings/org.eclipse.jdt.core.prefs:2:
> org.eclipse.jdt.core.formatter.insert_space_before_comma_in_for_inits=do not
> insert
> Looks like it should not be in the checkin.

Sorry about the noise. Please take a look at patchset #2.

[Anthony Moore, 2014-07-09 23:12:07]

Just one question about it.

https://codereview.appspot.com/111000043/diff/20001/google-api-client/src/mai...
File
google-api-client/src/main/java/com/google/api/client/googleapis/util/Utils.java
(left):

https://codereview.appspot.com/111000043/diff/20001/google-api-client/src/mai...
google-api-client/src/main/java/com/google/api/client/googleapis/util/Utils.java:59:
* {@link Beta} <br/>
Did you mean to take Beta off these? I thought we would have this since, they
are brand new, and would remove in the next release.

[wonderfly, 2014-07-09 23:33:15]

https://codereview.appspot.com/111000043/diff/20001/google-api-client/src/mai...
File
google-api-client/src/main/java/com/google/api/client/googleapis/util/Utils.java
(left):

https://codereview.appspot.com/111000043/diff/20001/google-api-client/src/mai...
google-api-client/src/main/java/com/google/api/client/googleapis/util/Utils.java:59:
* {@link Beta} <br/>
On 2014/07/09 23:12:07, Anthony Moore wrote:
> Did you mean to take Beta off these? I thought we would have this since, they
> are brand new, and would remove in the next release.

I marked the entire class as Beta since the only non-Beta method is now out.

[Anthony Moore, 2014-07-09 23:41:43]

LGTM