Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13190)

Issue 110960043: Issue 3999: Make tablature half-note stem-spacing adjustable.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by Mark Polesky
Modified:
9 years, 9 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

This adds a new property to the Stem grob called 'double-stem-separation (default=0.5), that allows users to adjust the space between the double-stemmed half-notes in tablature: \new TabStaff { \tabFullNotation c4 c2 c4 \override Stem.double-stem-separation = 0.3 c4 c2 c4 } It also centers the stems on the fret number and adjusts the X-extent accordingly. On the tracker: http://code.google.com/p/lilypond/issues/detail?id=3999

Patch Set 1 #

Total comments: 2

Patch Set 2 : Escape backslash in scheme code. #

Patch Set 3 : Don't look for stems on rests. #

Patch Set 4 : Optimize code. #

Patch Set 5 : Nitpick. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -15 lines) Patch
M lily/stem.cc View 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 chunk +1 line, -0 lines 0 comments Download
M scm/tablature.scm View 1 2 3 1 chunk +25 lines, -15 lines 0 comments Download

Messages

Total messages: 4
dak
https://codereview.appspot.com/110960043/diff/1/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): https://codereview.appspot.com/110960043/diff/1/scm/define-grob-properties.scm#newcode243 scm/define-grob-properties.scm:243: stems of a half note in tablature when using ...
9 years, 9 months ago (2014-07-09 07:02:48 UTC) #1
Mark Polesky
On 2014/07/09 07:02:48, dak wrote: > https://codereview.appspot.com/110960043/diff/1/scm/define-grob-properties.scm > File scm/define-grob-properties.scm (right): > > https://codereview.appspot.com/110960043/diff/1/scm/define-grob-properties.scm#newcode243 > ...
9 years, 9 months ago (2014-07-09 07:13:04 UTC) #2
Mark Polesky
On 2014/07/09 07:13:04, Mark Polesky wrote: > ...But TabStaff is not a regular staff, since ...
9 years, 9 months ago (2014-07-09 07:14:43 UTC) #3
dak
9 years, 9 months ago (2014-07-09 07:39:38 UTC) #4
On 2014/07/09 07:13:04, Mark Polesky wrote:
> On 2014/07/09 07:02:48, dak wrote:
> >
https://codereview.appspot.com/110960043/diff/1/scm/define-grob-properties.scm
> > File scm/define-grob-properties.scm (right):
> > 
> >
>
https://codereview.appspot.com/110960043/diff/1/scm/define-grob-properties.sc...
> > scm/define-grob-properties.scm:243: stems of a half note in tablature when
> using
> > @code{\tabFullNotation},
> > @code{\\tabFullNotation}
> 
> I always get confused with that.  Are there some places where @code{\foo} is
> allowed and other places where it is not?

Nothing confusing here.  In Texinfo, backslash is an ordinary character, so you
*always* write @code{\tabFullNotation} and similar in Texinfo.  But this Texinfo
section here is inside of a Scheme string, and backslashes in Scheme strings
need to be escaped.  Nothing to do with Texinfo.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b