Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(473)

Issue 110930043: code review 110930043: runtime: fix spurious "[string too long]" error (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by dvyukov
Modified:
6 years, 6 months ago
Reviewers:
gobot, iant, crawshaw
CC:
golang-codereviews, crawshaw, iant, khr, rsc
Visibility:
Public.

Description

runtime: fix spurious "[string too long]" error Maxstring is not updated in the new string routines, this makes runtime think that long strings are bogus. Fixes issue 8339.

Patch Set 1 #

Patch Set 2 : diff -r 991519645363 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 991519645363 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 5b3092ce6741 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M src/pkg/runtime/string_test.go View 1 2 chunks +23 lines, -0 lines 0 comments Download
M src/pkg/runtime/stubs.goc View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5
dvyukov
Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
6 years, 6 months ago (2014-07-08 14:12:44 UTC) #1
crawshaw
LGTM fwiw
6 years, 6 months ago (2014-07-08 15:08:49 UTC) #2
iant
LGTM
6 years, 6 months ago (2014-07-08 17:04:04 UTC) #3
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=676c213d0a46 *** runtime: fix spurious "[string too long]" error Maxstring is not ...
6 years, 6 months ago (2014-07-08 18:37:24 UTC) #4
gobot
6 years, 6 months ago (2014-07-08 22:27:13 UTC) #5
Message was sent while issue was closed.
This CL appears to have broken the nacl-amd64p32 builder.
See http://build.golang.org/log/a1fe2fbe18abcd29dce9303735e04b54c098391c
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b