Issue 110900043: code review 110900043: go.tools/playground/socket: add support for Native Clie...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 110900043: code review 110900043: go.tools/playground/socket: add support for Native Clie... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by kortschak

Modified:
11 years, 9 months ago

Reviewers:
minux

CC:
adg, minux, golang-codereviews

Visibility:
Public.

Description

go.tools/playground/socket: add support for Native Client on arm

Patch Set 2 : diff -r 42961892f314 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 42961892f314 https://code.google.com/p/go.tools #

Total comments: 4

Patch Set 4 : diff -r c1a4f11cf328 https://code.google.com/p/go.tools #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	playground/socket/socket.go	View	1 2 3	2 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

kortschak

Hello adg@golang.org, minux@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

11 years, 9 months ago (2014-07-08 05:48:28 UTC) #1

minux

https://codereview.appspot.com/110900043/diff/30001/playground/socket/socket.go File playground/socket/socket.go (right): https://codereview.appspot.com/110900043/diff/30001/playground/socket/socket.go#newcode350 playground/socket/socket.go:350: env = append(env, "NACLENV_GOARCH=amd64") should this be amd64p32? https://codereview.appspot.com/110900043/diff/30001/playground/socket/socket.go#newcode357 ...

11 years, 9 months ago (2014-07-08 16:00:56 UTC) #2

kortschak

PTAL https://codereview.appspot.com/110900043/diff/30001/playground/socket/socket.go File playground/socket/socket.go (right): https://codereview.appspot.com/110900043/diff/30001/playground/socket/socket.go#newcode350 playground/socket/socket.go:350: env = append(env, "NACLENV_GOARCH=amd64") On 2014/07/08 16:00:56, minux ...

11 years, 9 months ago (2014-07-09 02:31:11 UTC) #3

minux

11 years, 9 months ago (2014-07-09 02:40:40 UTC) #5

*** Submitted as
https://code.google.com/p/go/source/detail?r=9160ed396d7f&repo=tools ***

go.tools/playground/socket: add support for Native Client on arm

LGTM=minux
R=adg, minux
CC=golang-codereviews
https://codereview.appspot.com/110900043

Committer: Shenghou Ma <minux@golang.org>

Expand All Messages | Collapse All Messages