code review 110890043: net/rpc: use html/template to render html

net/rpc: use html/template to render html

Found using the vet check in CL 106370045.

This is a second attempt at CL 101670044, which omitted the deps_test change.

This adds dependencies to net/rpc:

        encoding
        encoding/base64
        encoding/json
        html
        unicode/utf16

The obvious correctness and security warrants the additional dependencies.

[josharian, 2014-07-08 00:30:31]

Hello r@golang.org, minux@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[minux, 2014-07-08 00:34:00]

R: +rsc.

[r, 2014-07-08 01:14:18]

new transitive dependencies: encoding encoding/base64 encoding/json html math
net/url

there are a couple of biggies in there. is it worth it? probably.

leaving for rsc

[adg, 2014-07-08 04:43:42]

On 8 July 2014 11:14, <r@golang.org> wrote:

> there are a couple of biggies in there


Which are big, in your opinion? math and json?

[josharian, 2014-07-08 19:48:39]

> new transitive dependencies: encoding encoding/base64 encoding/json html math
> net/url

FTR, math and net/url are already dependencies of text/template; I'm pretty sure
the list in the description is accurate.

$ go list -f '{{range .Deps}}{{.}}
{{end}}' text/template > t.deps
$ go list -f '{{range .Deps}}{{.}}
{{end}}' html/template > h.deps
$ diff t.deps h.deps 
1a2,4
> encoding
> encoding/base64
> encoding/json
3a7
> html
17a22
> text/template
20a26
> unicode/utf16

[rsc, 2014-07-09 16:34:29]

lgtm

it seems weird to me that net/rpc now depends on html, just to print a
status page. on the other hand i don't really care much about net/rpc. it
should have been in a subrepo.

[josharian, 2014-07-10 02:33:46]

*** Submitted as https://code.google.com/p/go/source/detail?r=d6c7ec5112ec ***

net/rpc: use html/template to render html

Found using the vet check in CL 106370045.

This is a second attempt at CL 101670044, which omitted the deps_test change.

This adds dependencies to net/rpc:

        encoding
        encoding/base64
        encoding/json
        html
        unicode/utf16

The obvious correctness and security warrants the additional dependencies.

LGTM=rsc
R=r, minux, rsc, adg
CC=golang-codereviews
https://codereview.appspot.com/110890043

[gobot, 2014-07-10 03:35:22]

This CL appears to have broken the plan9-386-cnielsen builder.
See http://build.golang.org/log/47c3094d07ea5dfa8d18ee9f9c0a8b7d8a916623

[josharian, 2014-07-10 04:13:38]

Unrelated.

This builder has been pretty flaky recently.



On Wed, Jul 9, 2014 at 8:35 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the plan9-386-cnielsen builder.
> See http://build.golang.org/log/47c3094d07ea5dfa8d18ee9f9c0a8b7d8a916623
>
> https://codereview.appspot.com/110890043/
>