Issue 110880044: code review 110880044: undo CL 101670044 / 49a6cbd80cf2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 110880044: code review 110880044: undo CL 101670044 / 49a6cbd80cf2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by josharian

Modified:
10 years, 11 months ago

Reviewers:

CC:
r, golang-codereviews

Visibility:
Public.

Description

undo CL 101670044 / 49a6cbd80cf2 Broke build; missing deps_test change. Will re-send the original with the appropriate fix. ««« original CL description net/rpc: use html/template to render html Found using the vet check in CL 106370045. LGTM=r R=golang-codereviews, r CC=golang-codereviews https://codereview.appspot.com/101670044 »»»

Patch Set 1 #

Patch Set 2 : diff -r 49a6cbd80cf2 https://code.google.com/p/go #

Patch Set 3 : diff -r 49a6cbd80cf2 https://code.google.com/p/go #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/net/rpc/debug.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

josharian

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 11 months ago (2014-07-08 00:10:31 UTC) #1

josharian

10 years, 11 months ago (2014-07-08 00:10:37 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=991519645363 ***

undo CL 101670044 / 49a6cbd80cf2

Broke build; missing deps_test change. Will re-send the original with the
appropriate fix.

««« original CL description
net/rpc: use html/template to render html

Found using the vet check in CL 106370045.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/101670044
»»»

TBR=r
CC=golang-codereviews
https://codereview.appspot.com/110880044

Expand All Messages | Collapse All Messages