Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1574)

Issue 11061044: Changes to MIB for Idle mode

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by buherman
Modified:
10 years, 9 months ago
Reviewers:
Marco Miozzo, mrequena, jaime.ferragut, Nicola Baldo, mmiozzo, nbaldo
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Changes to MIB for Idle mode

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated attempt to initial synchronization, cell search, MIB and SIB1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+827 lines, -177 lines) Patch
M src/lte/helper/lte-helper.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M src/lte/model/lte-control-messages.h View 1 2 chunks +34 lines, -0 lines 0 comments Download
M src/lte/model/lte-control-messages.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download
M src/lte/model/lte-enb-cphy-sap.h View 1 3 chunks +14 lines, -0 lines 0 comments Download
M src/lte/model/lte-enb-phy.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/lte/model/lte-enb-phy.cc View 1 2 chunks +23 lines, -0 lines 0 comments Download
M src/lte/model/lte-rrc-protocol-ideal.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/lte/model/lte-rrc-protocol-ideal.cc View 1 1 chunk +0 lines, -44 lines 0 comments Download
M src/lte/model/lte-rrc-protocol-real.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/lte/model/lte-rrc-protocol-real.cc View 1 1 chunk +0 lines, -44 lines 0 comments Download
M src/lte/model/lte-rrc-sap.h View 1 8 chunks +7 lines, -35 lines 0 comments Download
M src/lte/model/lte-spectrum-phy.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/lte/model/lte-ue-cphy-sap.h View 1 6 chunks +49 lines, -2 lines 0 comments Download
M src/lte/model/lte-ue-phy.h View 1 7 chunks +34 lines, -2 lines 0 comments Download
M src/lte/model/lte-ue-phy.cc View 1 11 chunks +184 lines, -30 lines 0 comments Download
M src/lte/model/lte-ue-rrc.h View 1 5 chunks +10 lines, -1 line 0 comments Download
M src/lte/model/lte-ue-rrc.cc View 1 5 chunks +59 lines, -9 lines 0 comments Download
A src/lte/test/lte-test-cell-selection.h View 1 1 chunk +105 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-cell-selection.cc View 1 1 chunk +276 lines, -0 lines 0 comments Download
M src/lte/wscript View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16
buherman
Hi all, I encountered some problems while working on initial cell selection. So I'm looking ...
10 years, 9 months ago (2013-07-10 16:34:38 UTC) #1
Marco Miozzo
A quick feedback for what concern the MIB implementation, it is fine with me, I ...
10 years, 9 months ago (2013-07-11 10:16:32 UTC) #2
Marco Miozzo
https://codereview.appspot.com/11061044/diff/1/src/lte/helper/lte-helper.cc File src/lte/helper/lte-helper.cc (right): https://codereview.appspot.com/11061044/diff/1/src/lte/helper/lte-helper.cc#newcode332 src/lte/helper/lte-helper.cc:332: ulPhy->SetChannel (m_uplinkChannel); What is the reason of moving the ...
10 years, 9 months ago (2013-07-11 10:16:40 UTC) #3
buherman
Hi Marco, thanks a lot for the feedback. Please see my comments below. Regards, -budi- ...
10 years, 9 months ago (2013-07-11 11:43:02 UTC) #4
Nicola Baldo
Hi Budi, I still did not look at the code, however I have one general ...
10 years, 9 months ago (2013-07-11 11:44:20 UTC) #5
buherman
Thanks, Nicola. Please see my comments inline below. On 2013/07/11 11:44:20, Nicola Baldo wrote: > ...
10 years, 9 months ago (2013-07-11 14:16:35 UTC) #6
Nicola Baldo
On 2013/07/11 14:16:35, buherman wrote: > On 2013/07/11 11:44:20, Nicola Baldo wrote: > > the ...
10 years, 9 months ago (2013-07-11 15:30:03 UTC) #7
buherman
Hi Nicola, Thanks again for the clarification. I've also been browsing the Internet for more ...
10 years, 9 months ago (2013-07-12 19:15:57 UTC) #8
jaime.ferragut_cttc.es
Hi all, Apologies for the delay, but I was busy with a paper deadline. Looks ...
10 years, 9 months ago (2013-07-15 09:21:21 UTC) #9
buherman
Thanks, Jaime. I get better understanding now, but still hope that I don't miss anything. ...
10 years, 9 months ago (2013-07-16 08:23:21 UTC) #10
Nicola Baldo
Hi Budi, thanks for the detailed description, your effort in re-designing the cell selection part ...
10 years, 9 months ago (2013-07-19 23:37:14 UTC) #11
buherman
Hi Nicola, Thanks, please find my comments below. On 2013/07/19 23:37:14, Nicola Baldo wrote: > ...
10 years, 9 months ago (2013-07-21 20:22:43 UTC) #12
Nicola Baldo
Hi Budi, I think we are converging on most points, please find below my comments ...
10 years, 9 months ago (2013-07-25 13:22:14 UTC) #13
buherman
Hi Nicola, Thanks for your comments. I think we're almost there. Just one more issue ...
10 years, 9 months ago (2013-07-26 11:45:57 UTC) #14
nbaldo_cttc.es
Hi Budi, On 07/26/2013 01:45 PM, budiarto.herman@magister.fi wrote: >> 6) the RRC reads the PLMN ...
10 years, 9 months ago (2013-07-26 15:08:52 UTC) #15
buherman
10 years, 9 months ago (2013-07-29 06:32:41 UTC) #16
Hi Nicola,

Thanks. I have a few comments below.

-budi-

On 2013/07/26 15:08:52, nbaldo_cttc.es wrote:
> > I see. Then I think it would be better if I rename the function
> > InitialCellSelection() in RRC to something like
> > EvaluateCellForSelection(). 
> 
> Yes that could be fine. Maybe "Cells"

Um.. but the function would only evaluate one cell, that is the cell the SIB1 is
received from.

I'm updating the documentation again, and I'll send it to you when I'm done.

> I think just blindly retrying won't work well. Quite often users will
> run scenarios with static nodes and no fading, so the strongest cell
> will stay strongest forever, and the macro UE will never camp on the cell.

Yes, therefore I mark this cell as "acceptable" by saving its cell ID to
m_acceptableCell. In the next turns, the UE won't attempt to synchronize to
cells listed in m_acceptableCell. This should prevent UE from retrying to the
same cell again and again.

> Well, at first PLMN seemed appealing and easy to do, but after all these
> discussions, I agree that having it makes little sense, at least until
> we have also multi-frequency scanning.
> 
> Anyway, it doesn't hurt to have the PLMN in system information, so I
> would leave it there.

Alright, I'll remove PLMN as cell selection criteria, and also remove the helper
function for setting PLMN ID on UE and eNodeB.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b