Issue 11039043: Don't die on badly formed issuer certificates

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11039043: Don't die on badly formed issuer certificates

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by Ben Laurie (Google)

Modified:
10 years, 9 months ago

Reviewers:
Eran

CC:
ctlog-opensource-review_google.com

Visibility:
Public.

More Reviews

Description

Don't die on badly formed issuer certificates

Patch Set 1 #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
	M	src/client/fix-chain.py	View		1 chunk	+12 lines, -5 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Eran

LGTM, see one minor comment. https://codereview.appspot.com/11039043/diff/1/src/client/fix-chain.py File src/client/fix-chain.py (right): https://codereview.appspot.com/11039043/diff/1/src/client/fix-chain.py#newcode116 src/client/fix-chain.py:116: print "Skipping issuer URL:", ...

10 years, 9 months ago (2013-07-09 13:20:07 UTC) #2

Ben Laurie (Google)

10 years, 9 months ago (2013-07-09 14:07:36 UTC) #3

Pushed.

https://codereview.appspot.com/11039043/diff/1/src/client/fix-chain.py
File src/client/fix-chain.py (right):

https://codereview.appspot.com/11039043/diff/1/src/client/fix-chain.py#newcod...
src/client/fix-chain.py:116: print "Skipping issuer URL:", str(loc)
On 2013/07/09 13:20:07, Eran wrote:
> No need to call str - print does that implicitly:
> http://docs.python.org/2/reference/datamodel.html#basic-customization

Done.

Expand All Messages | Collapse All Messages