tools: rename tools/ to agent/

tools: rename tools/ to agent/

This changes the top level package to 'agent', and
moves all of the code from environs/agent into that file.
This fits in with what Tim wants to do (drop state.Tools),
and what William and I agreed (environs/agent shouldn't
be in environs and doesn't, in fact, depend on environs anyway).

https://code.launchpad.net/~jameinel/juju-core/tools-to-agent/+merge/173703

(do not edit description out of merge proposal)

[jameinel, 2013-07-09 12:03:01]

Please take a look.

[fwereade, 2013-07-10 09:11:59]

LGTM

[jtv.canonical, 2013-07-10 11:31:59]

I'm in no position to judge the intended change, but then that's not what
reviews are really for.  LGTM, with some very minor notes about the commenting.

https://codereview.appspot.com/11036043/diff/1/agent/tools_compat_test.go
File agent/tools_compat_test.go (right):

https://codereview.appspot.com/11036043/diff/1/agent/tools_compat_test.go#new...
agent/tools_compat_test.go:20: // Just ensure you can simply cast the two types
to each other

This comment reads as if I'm missing something...  Maybe it's the "Just." 
There's no punctuation at the end, so maybe a line was accidentally deleted?

https://codereview.appspot.com/11036043/diff/1/agent/tools_compat_test.go#new...
agent/tools_compat_test.go:21: // When Tim's patch lands to use agent.Tools
everywhere, we can get rid of

Maybe make this a TODO?

Also, is this entire test file meant for that kind of test, or might others add
more tests here that should not be deleted?

In the former case, best document the file's purpose.  In the latter case, it'd
be helpful to be precise about which files should go — e.g. by repeating a
single TODO line for each.

[jameinel, 2013-07-10 13:14:47]

Please take a look.

https://codereview.appspot.com/11036043/diff/1/agent/tools_compat_test.go
File agent/tools_compat_test.go (right):

https://codereview.appspot.com/11036043/diff/1/agent/tools_compat_test.go#new...
agent/tools_compat_test.go:21: // When Tim's patch lands to use agent.Tools
everywhere, we can get rid of
On 2013/07/10 11:32:00, jtv.canonical wrote:
> 
> Maybe make this a TODO?
> 
> Also, is this entire test file meant for that kind of test, or might others
add
> more tests here that should not be deleted?
> 
> In the former case, best document the file's purpose.  In the latter case,
it'd
> be helpful to be precise about which files should go — e.g. by repeating a
> single TODO line for each.

I made it a TODO and made it clearer that the test suite (and file) can be
removed once we've transitioned to agent.Tools instead of state.Tools.