Issue 11035043: testing/channel: Add helpers for testing channels

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11035043: testing/channel: Add helpers for testing channels

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by jameinel

Modified:
10 years, 9 months ago

Reviewers:
mue, mp+173680, fwereade

Visibility:
Public.

Description

testing/channel: Add helpers for testing channels This adds some testing helpers to make it easier to do timeout-based assertions on how a channel operates. I then use this in worker/uniter/filter_test.go. The easier fix for filter_test.go would be just to use the LongWait and ShortWait constants. But I wanted to make it harder to use the wrong timeouts. I really like NotifyAsserterC (name is very flexible). However, I wish it was easier to test a channel of arbitrary content. It looks like reflect has some things we could use in go1.1 if we can get switched over. Mostly I want feedback before I go any deeper in this code. https://code.launchpad.net/~jameinel/juju-core/transient-failure-filter/+merge/173680 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+229 lines, -103 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/testing/watcher.go	View	5 chunks	+5 lines, -9 lines	0 comments	Download
A	testing/channel.go	View	1 chunk	+127 lines, -0 lines	0 comments	Download
A	testing/constants.go	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	worker/notifyworker_test.go	View	5 chunks	+8 lines, -20 lines	0 comments	Download
M	worker/uniter/filter_test.go	View	15 chunks	+67 lines, -74 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

LGTM. Would be nice to see these folded into the WatcherCs.

10 years, 9 months ago (2013-07-09 10:47:03 UTC) #2

LGTM

Expand All Messages | Collapse All Messages