Issue 11033044: code review 11033044: go.crypto/salsa: fix typo in comment and move TODO out ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11033044: code review 11033044: go.crypto/salsa: fix typo in comment and move TODO out ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by agl1

Modified:
10 years, 9 months ago

Reviewers:
r

CC:
goland-dev_googlegroups.com, r, golang-dev

Visibility:
Public.

Description

go.crypto/salsa: fix typo in comment and move TODO out of package comment. Thanks to Frithjof Schulze for noticing.

Patch Set 1 #

Patch Set 2 : diff -r 06b2614538ce https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r 06b2614538ce https://code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r 06b2614538ce https://code.google.com/p/go.crypto/ #

Patch Set 5 : diff -r e6ec41d36ff8 https://code.google.com/p/go.crypto/ #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	salsa20/salsa20.go	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

Hello goland-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/

10 years, 9 months ago (2013-07-13 16:46:06 UTC) #1

agl1

10 years, 9 months ago (2013-07-16 23:36:48 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=bcb404348307&repo=crypto ***

go.crypto/salsa: fix typo in comment and move TODO out of package comment.

Thanks to Frithjof Schulze for noticing.

R=goland-dev, r
CC=golang-dev
https://codereview.appspot.com/11033044

Expand All Messages | Collapse All Messages