code review 110330044: sync/atomic: nacl/arm support.

sync/atomic: nacl/arm support.

[minux, 2014-07-02 00:31:21]

Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2014-07-02 00:37:55]

LGTM

On Wed, Jul 2, 2014 at 10:31 AM,  <minux@golang.org> wrote:
> Reviewers: rsc, iant,
>
> Message:
> Hello rsc@golang.org, iant@golang.org (cc:
> golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> sync/atomic: nacl/arm support.
>
> Please review this at https://codereview.appspot.com/110330044/
>
> Affected files (+3, -3 lines):
>   M src/pkg/sync/atomic/asm_nacl_arm.s
>
>
> Index: src/pkg/sync/atomic/asm_nacl_arm.s
> ===================================================================
> copy from src/pkg/sync/atomic/asm_netbsd_arm.s
> copy to src/pkg/sync/atomic/asm_nacl_arm.s
> --- a/src/pkg/sync/atomic/asm_netbsd_arm.s
> +++ b/src/pkg/sync/atomic/asm_nacl_arm.s
> @@ -1,11 +1,11 @@
> -// Copyright 2013 The Go Authors.  All rights reserved.
> +// Copyright 2014 The Go Authors.  All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
>  #include "../../../cmd/ld/textflag.h"
>
> -// NetBSD/ARM atomic operations.
> -// TODO(minux): this only supports ARMv6K or higher.
> +// NaCl/ARM atomic operations.
> +// NaCl/ARM explicitly targets ARMv7A.
>
>  TEXT ·CompareAndSwapInt32(SB),NOSPLIT,$0
>         B ·CompareAndSwapUint32(SB)
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[rsc, 2014-07-09 16:16:04]

LGTM

[minux, 2014-07-10 19:15:00]

*** Submitted as https://code.google.com/p/go/source/detail?r=90b145a49a65 ***

sync/atomic: nacl/arm support.

LGTM=dave, rsc
R=rsc, iant, dave
CC=golang-codereviews
https://codereview.appspot.com/110330044

[gobot, 2014-07-10 23:47:06]

This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/7944629412632d198b7607e83d466c9748a49530