code review 11022043: cmd/ld: trivial: fix unhandled switch case

cmd/ld: trivial: fix unhandled switch case

Fix warning found by clang 3.3.

[dave_cheney.net, 2013-07-09 01:47:22]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[r, 2013-07-09 01:59:42]

LGTM

not really

[dave_cheney.net, 2013-07-09 02:04:17]

I can add a

 default:
      break;

if that is better

On Tue, Jul 9, 2013 at 11:59 AM,  <r@golang.org> wrote:
> LGTM
>
> not really
>
> https://codereview.appspot.com/11022043/

[r, 2013-07-09 02:07:12]

it's fine as is. my complaint is about the tool, not your code.

[dave_cheney.net, 2013-07-09 02:07:35]

Thanks r.

On Tue, Jul 9, 2013 at 12:06 PM, Rob Pike <r@golang.org> wrote:
> it's fine as is. my complaint is about the tool, not your code.

[dave_cheney.net, 2013-07-09 02:16:29]

*** Submitted as https://code.google.com/p/go/source/detail?r=000ecca1178d ***

cmd/ld: trivial: fix unhandled switch case

Fix warning found by clang 3.3.

R=rsc, r
CC=golang-dev
https://codereview.appspot.com/11022043

[minux1, 2013-07-09 05:48:09]

i wonder if we need -marm for arm.

[dave_cheney.net, 2013-07-09 05:50:19]

It doesn't seem to be required, this change is effectively a NOOP on
arm, but I don't think it would hurt to overspecify -marm, and it
would be consistent with cmd/go. Feel like submitting a change ?

On Tue, Jul 9, 2013 at 3:48 PM, minux <minux.ma@gmail.com> wrote:
> i wonder if we need -marm for arm.

[minux1, 2013-07-10 18:22:58]

On Tue, Jul 9, 2013 at 1:50 PM, Dave Cheney <dave@cheney.net> wrote:

> It doesn't seem to be required, this change is effectively a NOOP on
> arm, but I don't think it would hurt to overspecify -marm, and it
> would be consistent with cmd/go. Feel like submitting a change ?
>
i don't feel strong about that, i suggest we leave this to the people
implementing
external linking for arm (there was already a CL for that).

>
> On Tue, Jul 9, 2013 at 3:48 PM, minux <minux.ma@gmail.com> wrote:
> > i wonder if we need -marm for arm.
>

[dave_cheney.net, 2013-07-10 23:20:58]

SGTM. Thank you.

On Thu, Jul 11, 2013 at 4:22 AM, minux <minux.ma@gmail.com> wrote:
>
> On Tue, Jul 9, 2013 at 1:50 PM, Dave Cheney <dave@cheney.net> wrote:
>>
>> It doesn't seem to be required, this change is effectively a NOOP on
>> arm, but I don't think it would hurt to overspecify -marm, and it
>> would be consistent with cmd/go. Feel like submitting a change ?
>
> i don't feel strong about that, i suggest we leave this to the people
> implementing
> external linking for arm (there was already a CL for that).
>>
>>
>> On Tue, Jul 9, 2013 at 3:48 PM, minux <minux.ma@gmail.com> wrote:
>> > i wonder if we need -marm for arm.
>
>