Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 110210043: Improved the item metadata section GUI (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by ajgupta93
Modified:
9 years, 8 months ago
Reviewers:
thomas.j.waldmann, RogerHaase
Visibility:
Public.

Description

Improved the item metadata section GUI

Patch Set 1 #

Patch Set 2 : Added more sections to the meta data and also changed metadata view in foobar and modernized themes #

Patch Set 3 : Removed print statement and removed bootstrap classes from foobar and modernized themes #

Total comments: 2

Patch Set 4 : Added more fields to the meta info and odered them alphabetically, added color coding for broken li… #

Total comments: 18

Patch Set 5 : Changed function names and removed duplicate code #

Patch Set 6 : Changed "Name Old" to "Old Name" #

Patch Set 7 : Removed check for local wiki #

Total comments: 7

Patch Set 8 : Changed " : " to ": " #

Patch Set 9 : Used safe filter for external links, and link_itemname to itemname #

Patch Set 10 : Correction #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -10 lines) Patch
M MoinMoin/apps/frontend/views.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M MoinMoin/items/__init__.py View 1 2 3 4 3 chunks +10 lines, -5 lines 0 comments Download
M MoinMoin/templates/meta.html View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M MoinMoin/templates/utils.html View 1 2 3 4 5 6 7 8 9 1 chunk +80 lines, -0 lines 0 comments Download
M MoinMoin/themes/__init__.py View 1 2 3 4 5 6 7 8 1 chunk +9 lines, -0 lines 0 comments Download
M MoinMoin/themes/basic/templates/meta.html View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10
RogerHaase
https://codereview.appspot.com/110210043/diff/40001/MoinMoin/themes/basic/templates/meta.html File MoinMoin/themes/basic/templates/meta.html (right): https://codereview.appspot.com/110210043/diff/40001/MoinMoin/themes/basic/templates/meta.html#newcode21 MoinMoin/themes/basic/templates/meta.html:21: <ul class="list-group"> These list-group classes are from bootstrap? Can ...
9 years, 9 months ago (2014-06-26 20:06:31 UTC) #1
RogerHaase
looks good, commit
9 years, 9 months ago (2014-06-27 15:16:46 UTC) #2
Thomas.J.Waldmann
https://codereview.appspot.com/110210043/diff/20002/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): https://codereview.appspot.com/110210043/diff/20002/MoinMoin/apps/frontend/views.py#newcode553 MoinMoin/apps/frontend/views.py:553: meta_rendered=item._render_meta(), why did you remove Markup()? https://codereview.appspot.com/110210043/diff/20002/MoinMoin/items/__init__.py File MoinMoin/items/__init__.py ...
9 years, 9 months ago (2014-06-27 15:27:34 UTC) #3
ajgupta93
https://codereview.appspot.com/110210043/diff/20002/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): https://codereview.appspot.com/110210043/diff/20002/MoinMoin/apps/frontend/views.py#newcode553 MoinMoin/apps/frontend/views.py:553: meta_rendered=item._render_meta(), On 2014/06/27 15:27:34, Thomas.J.Waldmann wrote: > why did ...
9 years, 9 months ago (2014-06-27 16:06:22 UTC) #4
Thomas.J.Waldmann
https://codereview.appspot.com/110210043/diff/20002/MoinMoin/themes/__init__.py File MoinMoin/themes/__init__.py (right): https://codereview.appspot.com/110210043/diff/20002/MoinMoin/themes/__init__.py#newcode489 MoinMoin/themes/__init__.py:489: if is_local_wiki(wikiname): getInterwikiHome(name) returns the location of the user ...
9 years, 9 months ago (2014-06-29 16:25:57 UTC) #5
ajgupta93
https://codereview.appspot.com/110210043/diff/20002/MoinMoin/themes/__init__.py File MoinMoin/themes/__init__.py (right): https://codereview.appspot.com/110210043/diff/20002/MoinMoin/themes/__init__.py#newcode489 MoinMoin/themes/__init__.py:489: if is_local_wiki(wikiname): On 2014/06/29 16:25:57, Thomas.J.Waldmann wrote: > getInterwikiHome(name) ...
9 years, 9 months ago (2014-06-30 16:31:20 UTC) #6
Thomas.J.Waldmann
https://codereview.appspot.com/110210043/diff/20002/MoinMoin/themes/__init__.py File MoinMoin/themes/__init__.py (right): https://codereview.appspot.com/110210043/diff/20002/MoinMoin/themes/__init__.py#newcode489 MoinMoin/themes/__init__.py:489: if is_local_wiki(wikiname): please answer my question.
9 years, 8 months ago (2014-07-06 15:35:37 UTC) #7
Thomas.J.Waldmann
https://codereview.appspot.com/110210043/diff/140001/MoinMoin/templates/utils.html File MoinMoin/templates/utils.html (right): https://codereview.appspot.com/110210043/diff/140001/MoinMoin/templates/utils.html#newcode108 MoinMoin/templates/utils.html:108: <li class="list-group-item">Action : {{ meta['action'] }}</li> do a search ...
9 years, 8 months ago (2014-07-12 15:42:47 UTC) #8
ajgupta93
https://codereview.appspot.com/110210043/diff/140001/MoinMoin/templates/utils.html File MoinMoin/templates/utils.html (right): https://codereview.appspot.com/110210043/diff/140001/MoinMoin/templates/utils.html#newcode108 MoinMoin/templates/utils.html:108: <li class="list-group-item">Action : {{ meta['action'] }}</li> On 2014/07/12 15:42:47, ...
9 years, 8 months ago (2014-07-14 12:19:14 UTC) #9
Thomas.J.Waldmann
9 years, 8 months ago (2014-07-17 16:10:33 UTC) #10
https://codereview.appspot.com/110210043/diff/140001/MoinMoin/templates/utils...
File MoinMoin/templates/utils.html (right):

https://codereview.appspot.com/110210043/diff/140001/MoinMoin/templates/utils...
MoinMoin/templates/utils.html:116: <a href="{{ item }}">
no, not done. I doubt that works and even if it does: you fixed the wrong place
(and you didn't test it).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b