Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(46)

Issue 110200046: LIB Fix b/15187210: Better log message when dashboard login fails (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by Brett
Modified:
7 years, 3 months ago
Reviewers:
pjo
CC:
connector-cr_google.com
Visibility:
Public.

Description

This change will include the GSA admin URL in the log message when failing to connect the the GSA admin port for authentication. Note that this was somewhat difficult since the error originates from deep within GData apis. It would be better if the URI would have been included in construction of the original exception: com.google.gdata.util.AuthenticationException: Error connecting with login URI This only fixes messages logged in the log file, and not the error message that is displayed on the dashboard login page.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Better log messages in general for failed GSA communications #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java View 1 2 chunks +30 lines, -1 line 2 comments Download

Messages

Total messages: 8
Brett
7 years, 3 months ago (2014-06-27 00:36:10 UTC) #1
pjo
Thank you. https://codereview.appspot.com/110200046/diff/1/src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java File src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java (right): https://codereview.appspot.com/110200046/diff/1/src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java#newcode205 src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java:205: if (e.getCause() instanceof ConnectException) { does this ...
7 years, 3 months ago (2014-06-27 01:28:22 UTC) #2
Brett
https://codereview.appspot.com/110200046/diff/1/src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java File src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java (right): https://codereview.appspot.com/110200046/diff/1/src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java#newcode205 src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java:205: if (e.getCause() instanceof ConnectException) { On 2014/06/27 01:28:22, pjo ...
7 years, 3 months ago (2014-06-27 22:18:39 UTC) #3
pjo
Sorry for not being clear. It seems in the authn() method we get exceptions whose ...
7 years, 3 months ago (2014-06-27 22:21:09 UTC) #4
brett.michael.johnson_gmail.com
We are are logging the exceptions (at FINE???) in Then we log it again after ...
7 years, 3 months ago (2014-06-27 22:38:26 UTC) #5
Brett
Better log messages in general for failed GSA communications
7 years, 3 months ago (2014-06-28 00:48:15 UTC) #6
pjo
Thank you. LGTM. https://codereview.appspot.com/110200046/diff/20001/src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java File src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java (right): https://codereview.appspot.com/110200046/diff/20001/src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java#newcode205 src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java:205: + "Console at " + adminUrl() ...
7 years, 3 months ago (2014-06-28 00:57:00 UTC) #7
Brett
7 years, 3 months ago (2014-06-28 01:32:17 UTC) #8
Committed 27 June 2014 to the Adaptor Library:

To https://code.google.com/p/plexi/
   a15692a..6451260  master -> master

https://codereview.appspot.com/110200046/diff/20001/src/com/google/enterprise...
File src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java
(right):

https://codereview.appspot.com/110200046/diff/20001/src/com/google/enterprise...
src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java:205: +
"Console at " + adminUrl() + " . If the GSA is not offline "
On 2014/06/28 00:57:00, pjo wrote:
> s/not offline/online/
> ?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b