code review 110160044: cmd/gc: drop parenthesization restriction for receiver types

cmd/gc: drop parenthesization restriction for receiver types

Matches CL 101500044.

[rsc, 2014-06-24 20:47:14]

Hello gri (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[gri, 2014-06-24 23:23:27]

LGTM

Nice to see all that code go.

[gri, 2014-06-24 23:30:00]

https://codereview.appspot.com/110160044/diff/40001/test/fixedbugs/bug299.go
File test/fixedbugs/bug299.go (right):

https://codereview.appspot.com/110160044/diff/40001/test/fixedbugs/bug299.go#...
test/fixedbugs/bug299.go:27: func (p (*T)) h() {}
perhaps add:

func (p (*(T))) i()  {}
func ((T),) j() {}

[rsc, 2014-06-25 13:57:56]

*** Submitted as https://code.google.com/p/go/source/detail?r=2699961d1143 ***

cmd/gc: drop parenthesization restriction for receiver types

Matches CL 101500044.

LGTM=gri
R=gri
CC=golang-codereviews
https://codereview.appspot.com/110160044

[gobot, 2014-06-25 13:59:22]

This CL appears to have broken the linux-386-387 builder.
See http://build.golang.org/log/ca59372886ef67c331325d0ec9a63b77cb255da5

[dave_cheney.net, 2014-06-25 14:09:41]

You win a gcc segfault.

# Building compilers and Go bootstrap tool for host, linux/386.
lib9
libbio
gcc: internal compiler error: Segmentation fault (program as)
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-4.8/README.Bugs> for instructions.
go tool dist: FAILED: gcc -Wall -Wstrict-prototypes -Wextra -Wunused
-Wno-sign-compare -Wno-missing-braces -Wno-parentheses
-Wno-unknown-pragmas -Wno-switch -Wno-comment
-Wno-missing-field-initializers -Werror -fno-common -ggdb -pipe
-Wuninitialized -O2 -fmessage-length=0 -c -m32 -I
/tmp/gobuilder/linux-386-387-2699961d1143/go/include -I
/tmp/gobuilder/linux-386-387-2699961d1143/go/src/libbio -o
$WORK/bfildes.o
/tmp/gobuilder/linux-386-387-2699961d1143/go/src/libbio/bfildes.c
Build complete, duration 30.367615785s. Result: error: exit status 1

On Wed, Jun 25, 2014 at 11:59 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the linux-386-387 builder.
> See http://build.golang.org/log/ca59372886ef67c331325d0ec9a63b77cb255da5
>
>
> https://codereview.appspot.com/110160044/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[rsc, 2014-06-26 15:22:32]

Given that the build hadn't gotten to any of the code I changed yet, I
think this is a bad machine.