Issue 11001043: More drag and drop refinement.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by benji

Modified:
10 years, 9 months ago

Reviewers:
jeff.pihach, matthew.scott, mp+173509

Visibility:
Public.

Description

More drag and drop refinement. - drag and drop now works with service inspector - several refactorings from review of last branch https://code.launchpad.net/~benji/juju-gui/drag-and-drop-follow-up/+merge/173509 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : More drag and drop refinement. #

Total comments: 5

Patch Set 3 : More drag and drop refinement. #

Patch Set 4 : More drag and drop refinement. #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+158 lines, -38 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	app/views/charm-panel.js	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	app/views/ghost-inspector.js	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	app/views/topology/service.js	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	app/widgets/charm-token.js	View	1 2	5 chunks	+23 lines, -16 lines	0 comments	Download
M	lib/views/browser/charm-token.less	View		4 chunks	+5 lines, -3 lines	0 comments	Download
M	test/test_charm_panel.js	View		1 chunk	+38 lines, -8 lines	0 comments	Download
M	test/test_charm_token_drag_and_drop.js	View		3 chunks	+73 lines, -7 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

jeff.pihach

LGTM with some small documentation requests great cleanup! https://codereview.appspot.com/11001043/diff/4001/app/views/topology/service.js File app/views/topology/service.js (right): https://codereview.appspot.com/11001043/diff/4001/app/views/topology/service.js#newcode426 app/views/topology/service.js:426: Y.one('body').setStyle('overflow', ...

10 years, 9 months ago (2013-07-08 14:19:14 UTC) #3

benji

Please take a look. https://codereview.appspot.com/11001043/diff/4001/app/views/topology/service.js File app/views/topology/service.js (right): https://codereview.appspot.com/11001043/diff/4001/app/views/topology/service.js#newcode426 app/views/topology/service.js:426: Y.one('body').setStyle('overflow', 'auto'); On 2013/07/08 14:19:14, ...

10 years, 9 months ago (2013-07-08 15:22:19 UTC) #4

benji

10 years, 9 months ago (2013-07-08 16:16:28 UTC) #6

*** Submitted:

More drag and drop refinement.

- drag and drop now works with service inspector
- several refactorings from review of last branch

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/11001043

Expand All Messages | Collapse All Messages