code review 109970043: doc/contribute: reorder documented steps to match norma...

doc/contribute: reorder documented steps to match normal workflow.

[wathiede, 2014-06-15 16:52:13]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[wathiede, 2014-06-15 16:56:35]

On 2014/06/15 16:52:13, wathiede wrote:
> Hello mailto:golang-codereviews@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go

I recently left a code review dangling after having run 'hg change', failing to
run 'hg mail', because I was following the Contribution Guideline and stopped
reading when I hit the section titled 'Adding or removing files from an existing
change' and figured 'That is something I'll read after I get review feedback if
it is necessary'.  

Would this reording, moving 'Mail the change for review' / 'Reviewing code' /
'Revise and upload', above 'Adding or removing files from an existing change' /
'Synchronize your client', be welcome and hopefully helpful to others?

[bradfitz, 2014-06-15 19:11:46]

R=adg



On Sun, Jun 15, 2014 at 9:56 AM, <couchmoney@gmail.com> wrote:

> On 2014/06/15 16:52:13, wathiede wrote:
>
>> Hello mailto:golang-codereviews@googlegroups.com,
>>
>
>  I'd like you to review this change to
>> https://code.google.com/p/go
>>
>
> I recently left a code review dangling after having run 'hg change',
> failing to run 'hg mail', because I was following the Contribution
> Guideline and stopped reading when I hit the section titled 'Adding or
> removing files from an existing change' and figured 'That is something
> I'll read after I get review feedback if it is necessary'.
>
> Would this reording, moving 'Mail the change for review' / 'Reviewing
> code' / 'Revise and upload', above 'Adding or removing files from an
> existing change' / 'Synchronize your client', be welcome and hopefully
> helpful to others?
>
> https://codereview.appspot.com/109970043/
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[adg, 2014-06-16 00:24:55]

LGTM

[wathiede, 2014-07-03 04:42:43]

On 2014/06/16 00:24:55, adg wrote:
> LGTM

What is the next step toward getting this submitted?

[minux, 2014-07-03 21:42:26]

*** Submitted as https://code.google.com/p/go/source/detail?r=3a3269902fa7 ***

doc/contribute: reorder documented steps to match normal workflow.

LGTM=adg
R=golang-codereviews, bradfitz, adg
CC=golang-codereviews
https://codereview.appspot.com/109970043

Committer: Shenghou Ma <minux@golang.org>