Move state initialization out of jujud bootstrap

Move state initialization out of jujud bootstrap

Methods to configure the initial state connection and dealing
with passwords were inside the jujud bootstrap command, which
isn't going to be used by the local provider, so the functions
need to be extracted.

https://code.launchpad.net/~thumper/juju-core/environ-bootstrap/+merge/173390

Requires: https://code.launchpad.net/~thumper/juju-core/local-provider-storage/+merge/173386

(do not edit description out of merge proposal)

[thumper, 2013-07-08 01:21:00]

Please take a look.

[dave_cheney.net, 2013-07-08 01:55:38]

LGTM. Thank you.

https://codereview.appspot.com/10990043/diff/1/environs/bootstrap.go
File environs/bootstrap.go (right):

https://codereview.appspot.com/10990043/diff/1/environs/bootstrap.go#newcode66
environs/bootstrap.go:66: 
comment please

https://codereview.appspot.com/10990043/diff/1/environs/bootstrap.go#newcode68
environs/bootstrap.go:68: logger.Debugf("add admin user")
adding admin user

https://codereview.appspot.com/10990043/diff/1/environs/bootstrap.go#newcode89
environs/bootstrap.go:89: 
comment please

[mue, 2013-07-08 08:44:14]

LGTM, only one wish for a name change.

https://codereview.appspot.com/10990043/diff/1/environs/bootstrap.go
File environs/bootstrap.go (right):

https://codereview.appspot.com/10990043/diff/1/environs/bootstrap.go#newcode66
environs/bootstrap.go:66: 
On 2013/07/08 01:55:38, dfc wrote:
> comment please

+1

https://codereview.appspot.com/10990043/diff/1/environs/bootstrap.go#newcode67
environs/bootstrap.go:67: func BootstrapMongoUsers(st *state.State, cfg
*config.Config, passwordHash string) error {
Would prefer a technology independent name here: 

- BootstrapUsers()
- BootstrapDatabaseUsers()
- BootstrapstateUsers()
- ...

https://codereview.appspot.com/10990043/diff/1/environs/bootstrap.go#newcode89
environs/bootstrap.go:89: 
On 2013/07/08 01:55:38, dfc wrote:
> comment please

+1

[thumper, 2013-07-08 22:48:13]

https://codereview.appspot.com/10990043/diff/1/environs/bootstrap.go
File environs/bootstrap.go (right):

https://codereview.appspot.com/10990043/diff/1/environs/bootstrap.go#newcode66
environs/bootstrap.go:66: 
On 2013/07/08 08:44:14, mue wrote:
> On 2013/07/08 01:55:38, dfc wrote:
> > comment please
> 
> +1

Done.

https://codereview.appspot.com/10990043/diff/1/environs/bootstrap.go#newcode67
environs/bootstrap.go:67: func BootstrapMongoUsers(st *state.State, cfg
*config.Config, passwordHash string) error {
On 2013/07/08 08:44:14, mue wrote:
> Would prefer a technology independent name here: 
> 
> - BootstrapUsers()
> - BootstrapDatabaseUsers()
> - BootstrapstateUsers()
> - ...

BootstrapUsers it is.

https://codereview.appspot.com/10990043/diff/1/environs/bootstrap.go#newcode68
environs/bootstrap.go:68: logger.Debugf("add admin user")
On 2013/07/08 01:55:38, dfc wrote:
> adding admin user

Done.

https://codereview.appspot.com/10990043/diff/1/environs/bootstrap.go#newcode89
environs/bootstrap.go:89: 
On 2013/07/08 08:44:14, mue wrote:
> On 2013/07/08 01:55:38, dfc wrote:
> > comment please
> 
> +1

Done.