Issue 10988043: code review 10988043: odbc: treat SQL_NO_DATA after SQLExecute call as success

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10988043: code review 10988043: odbc: treat SQL_NO_DATA after SQLExecute call as success (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by brainman

Modified:
12 years ago

Reviewers:

CC:
brainman

Visibility:
Public.

Description

odbc: treat SQL_NO_DATA after SQLExecute call as success Fixes issue 11

Patch Set 1 #

Patch Set 2 : diff -r d6c8ba201097 https://code.google.com/p/odbc #

Patch Set 3 : diff -r d6c8ba201097 https://code.google.com/p/odbc #

Patch Set 4 : diff -r d6c8ba201097 https://code.google.com/p/odbc #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
	M	mssql_test.go	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download
	M	odbcstmt.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

brainman

Hello brainman, I'd like you to review this change to https://code.google.com/p/odbc

12 years ago (2013-07-08 00:22:27 UTC) #1

brainman

12 years ago (2013-07-09 02:44:48 UTC) #2

*** Submitted as https://code.google.com/p/odbc/source/detail?r=73cbd9ce014c ***

odbc: treat SQL_NO_DATA after SQLExecute call as success

Fixes issue 11

R=alex.brainman
CC=brainman
https://codereview.appspot.com/10988043

Expand All Messages | Collapse All Messages