Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(125)

Issue 10980043: code review 10980043: syscall: implement Sendfile for Darwin. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by minux1
Modified:
7 years, 6 months ago
Reviewers:
rsc, dfc
CC:
golang-dev, rsc, dfc
Visibility:
Public.

Description

syscall: implement Sendfile for Darwin. Update issue 5847 Summary: syscall: implement Sendfile for OpenBSD and NetBSD

Patch Set 1 #

Patch Set 2 : diff -r cf792c00f410 https://code.google.com/p/go/ #

Patch Set 3 : diff -r cf792c00f410 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r fc06b300732a https://code.google.com/p/go/ #

Patch Set 5 : diff -r 417ffa35197c https://code.google.com/p/go/ #

Patch Set 6 : diff -r 71b65f4dbe6f https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -5 lines) Patch
M doc/go1.2.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/syscall/syscall_darwin.go View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/pkg/syscall/syscall_darwin_386.go View 1 2 chunks +15 lines, -0 lines 0 comments Download
M src/pkg/syscall/syscall_darwin_amd64.go View 1 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5
minux1
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
7 years, 6 months ago (2013-07-07 15:05:32 UTC) #1
minux1
https://codereview.appspot.com/10980043/diff/6001/src/pkg/syscall/syscall_darwin_amd64.go File src/pkg/syscall/syscall_darwin_amd64.go (right): https://codereview.appspot.com/10980043/diff/6001/src/pkg/syscall/syscall_darwin_amd64.go#newcode70 src/pkg/syscall/syscall_darwin_amd64.go:70: func Syscall9(num, a1, a2, a3, a4, a5, a6, a7, ...
7 years, 6 months ago (2013-07-07 15:09:02 UTC) #2
rsc
LGTM You can leave the go1.2.txt addition in this CL, but I doubt we're going ...
7 years, 6 months ago (2013-07-08 19:33:12 UTC) #3
dfc
On 2013/07/08 19:33:12, rsc wrote: > LGTM > > You can leave the go1.2.txt addition ...
7 years, 6 months ago (2013-07-11 03:10:49 UTC) #4
minux1
7 years, 6 months ago (2013-07-11 20:35:06 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=f50f0c6630d1 ***

syscall: implement Sendfile for Darwin.
Update issue 5847
Summary: syscall: implement Sendfile for OpenBSD and NetBSD

R=golang-dev, rsc, dave
CC=golang-dev
https://codereview.appspot.com/10980043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b