Issue 109780045: CH changes to resolve port conflicts in CF

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 109780045: CH changes to resolve port conflicts in CF

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by johnsca

Modified:
9 years, 10 months ago

Reviewers:
mp+222669, whit.morriss, benjamin.saller

Visibility:
Public.

Description

CH changes to resolve port conflicts in CF https://code.launchpad.net/~johnsca/charm-helpers/port-conflicts/+merge/222669 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : CH changes to resolve port conflicts in CF #

Patch Set 3 : CH changes to resolve port conflicts in CF #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+155 lines, -89 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charmhelpers/contrib/cloudfoundry/contexts.py	View		3 chunks	+17 lines, -6 lines	0 comments	Download
M	charmhelpers/core/services.py	View	1	5 chunks	+93 lines, -56 lines	0 comments	Download
M	tests/contrib/cloudfoundry/test_render_context.py	View		2 chunks	+9 lines, -10 lines	0 comments	Download
M	tests/core/test_services.py	View	1	4 chunks	+34 lines, -17 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

whit.morriss

On 2014/06/10 15:54:14, johnsca wrote: > Please take a look. at a glance LGTM

9 years, 10 months ago (2014-06-11 21:56:15 UTC) #2

benjamin.saller

LGTM but you knew that, I approved the derived branches already :)

9 years, 10 months ago (2014-06-11 23:43:20 UTC) #3

johnsca

9 years, 10 months ago (2014-06-12 17:31:18 UTC) #6

*** Submitted:

CH changes to resolve port conflicts in CF

R=whit.morriss, benjamin.saller
CC=
https://codereview.appspot.com/109780045

Expand All Messages | Collapse All Messages