Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(956)

Issue 10964045: Make charm browser title be ellipsised.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by bac
Modified:
10 years, 9 months ago
Reviewers:
benji, mp+174495, gary.poster
Visibility:
Public.

Description

Make charm browser title be ellipsised. https://code.launchpad.net/~bac/juju-gui/charm-title-ellipsis/+merge/174495 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Make charm browser title be ellipsised. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M lib/views/browser/charm-token.less View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4
bac
Please take a look.
10 years, 9 months ago (2013-07-12 20:11:06 UTC) #1
benji
LGTM. I have been waiting 11 years to be able to do ellipsis with just ...
10 years, 9 months ago (2013-07-12 20:15:33 UTC) #2
gary.poster
LGTM! Thank you
10 years, 9 months ago (2013-07-12 20:24:10 UTC) #3
bac
10 years, 9 months ago (2013-07-12 20:41:45 UTC) #4
*** Submitted:

Make charm browser title be ellipsised.

R=benji, gary.poster
CC=
https://codereview.appspot.com/10964045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b