Issue 10962043: state/testing: pull out SetAgentVersion

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10962043: state/testing: pull out SetAgentVersion

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by jameinel

Modified:
10 years, 10 months ago

Reviewers:
mp+173175, rvb, mue, dave

Visibility:
Public.

Description

state/testing: pull out SetAgentVersion There were two test cases that wanted SetAgentVersion, and I wanted to add a third. So this is a trivial "pull it out into a common testing helper". https://code.launchpad.net/~jameinel/juju-core/set-agent-version/+merge/173175 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -33 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/jujutest/livetests.go	View	3 chunks	+2 lines, -15 lines	0 comments	Download
M	state/state_test.go	View	2 chunks	+4 lines, -18 lines	0 comments	Download
A	state/testing/agent.go	View	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

10 years, 10 months ago (2013-07-08 02:14:05 UTC) #4

On 2013/07/05 11:54:46, mue wrote:
> LGTM, simple and clean.

LGTM. Thanks.

Expand All Messages | Collapse All Messages