Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(309)

Issue 109600044: code review 109600044: test: add test for issue8347 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by minux
Modified:
10 years, 8 months ago
Reviewers:
gobot, dave
CC:
golang-codereviews, dave_cheney.net
Visibility:
Public.

Description

test: add test for issue8347 Fixes issue 8347.

Patch Set 1 #

Patch Set 2 : diff -r eae7f816eb6c https://code.google.com/p/go #

Patch Set 3 : diff -r eae7f816eb6c https://code.google.com/p/go #

Patch Set 4 : diff -r eae7f816eb6c https://code.google.com/p/go #

Patch Set 5 : diff -r f749e3111252 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
A test/fixedbugs/issue8347.go View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 5
minux
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 8 months ago (2014-07-09 01:24:50 UTC) #1
dave_cheney.net
LGTM. Please add a newline between the title and the description.
10 years, 8 months ago (2014-07-09 01:39:14 UTC) #2
minux
*** Submitted as https://code.google.com/p/go/source/detail?r=ac84ecc92810 *** test: add test for issue8347 Fixes issue 8347. LGTM=dave R=golang-codereviews, ...
10 years, 8 months ago (2014-07-19 00:59:58 UTC) #3
gobot
This CL appears to have broken the netbsd-amd64-bsiegert builder. See http://build.golang.org/log/69855a8b93780ff91b30ffe93b4a0e783dde6ee4
10 years, 8 months ago (2014-07-19 02:09:07 UTC) #4
minux
10 years, 8 months ago (2014-07-19 02:13:07 UTC) #5
On Fri, Jul 18, 2014 at 10:09 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the netbsd-amd64-bsiegert builder.
> See http://build.golang.org/log/69855a8b93780ff91b30ffe93b4a0e783dde6ee
> <http://build.golang.org/log/69855a8b93780ff91b30ffe93b4a0e783dde6ee4>

False.

# GOMAXPROCS=2 runtime -cpu=1,2,4
--- FAIL: TestFinalizerType-4 (4.02s)
mfinal_test.go:61: finalizer for type func(*int) didn't run
FAIL
FAIL runtime 199.677s
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b