Further break up cloudinit.

Further break up cloudinit.

Move the definitions of the mongo and machine agent
services into the upstart package.  These have been
parameterized to allow reuse in the local provider.

There definitions have been moved from the cloudinit
function, and as you can see there are two different
ways of defining the command.  I have left it up to
the reviewers to decide which is better.  Personally
I'm leaning towards the style used to define the
mongo service.

Also, wondering about specific tests for these. They
don't really do much except format the parameters
for a new object.

https://code.launchpad.net/~thumper/juju-core/upstart-services/+merge/173121

Requires: https://code.launchpad.net/~thumper/juju-core/find-ipv4-address/+merge/173119

(do not edit description out of merge proposal)

[thumper, 2013-07-05 01:31:00]

Please take a look.

[thumper, 2013-07-05 01:53:17]

Please take a look.

[mue, 2013-07-05 07:44:01]

I really like the approach, but would also like isolated tests for the new
upstart functions.

[wallyworld, 2013-07-08 01:38:17]

LGTM. I prefer the string concatenation as it's easier to read. I also don't
think tests for the struct creation will add too much value. I see this as a
minor, internal implementation detail. So long as there are other tests that
check things like the contents of the upstart files, that to me is sufficient.

[thumper, 2013-07-08 02:58:51]

On 2013/07/08 01:38:17, wallyworld wrote:
> LGTM. I prefer the string concatenation as it's easier to read. I also don't
> think tests for the struct creation will add too much value. I see this as a
> minor, internal implementation detail. So long as there are other tests that
> check things like the contents of the upstart files, that to me is sufficient.

Restructured.

[thumper, 2013-07-08 03:05:32]

Please take a look.

[dave_cheney.net, 2013-07-08 06:36:50]

LGTM.

https://codereview.appspot.com/10952043/diff/9001/environs/cloudinit/cloudini...
File environs/cloudinit/cloudinit.go (right):

https://codereview.appspot.com/10952043/diff/9001/environs/cloudinit/cloudini...
environs/cloudinit/cloudinit.go:288: dbDir := path.Join(cfg.DataDir, "db")
ohh, this is a tricky one. Ideally you should use filepath.Join, but that means
on win32 clients, they will screw this up completely. good catch.