code review 109470043: runtime: export _rt0 for android

runtime: export _rt0 for android

[crawshaw, 2014-07-04 15:57:26]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[minux, 2014-07-05 03:46:40]

> +void _rt0_arm_linux1();
> +#pragma cgo_export_static _rt0_arm_linux1
> +#pragma cgo_export_dynamic _rt0_arm_linux1
where is this entry point defined?
i'm using my phone right now so i can't easily consult the code.

btw, when will the android builder be available?

thanks.

[crawshaw, 2014-07-05 12:57:42]

On Fri, Jul 4, 2014 at 11:46 PM, minux <minux@golang.org> wrote:
>
>> +void _rt0_arm_linux1();
>> +#pragma cgo_export_static _rt0_arm_linux1
>> +#pragma cgo_export_dynamic _rt0_arm_linux1
> where is this entry point defined?
> i'm using my phone right now so i can't easily consult the code.

_rt0_arm_linux1 is defined in  pkg/runtime/rt0_linux_arm.s.

> btw, when will the android builder be available?

With cl/110360044 I hope to get a green android/arm builder next week,
and maybe an android/x86 builder.

> thanks.

[iant, 2014-07-05 19:44:34]

LGTM

[minux, 2014-07-05 23:30:09]

LGTM.

[crawshaw, 2014-07-07 11:35:53]

*** Submitted as https://code.google.com/p/go/source/detail?r=690153652172 ***

runtime: export _rt0 for android

LGTM=iant, minux
R=golang-codereviews, minux, iant
CC=golang-codereviews
https://codereview.appspot.com/109470043

[gobot, 2014-07-07 11:48:33]

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/b0722fe3828188c8708c717ff3d7c826042f29f5

[crawshaw, 2014-07-07 12:10:48]

On Mon, Jul 7, 2014 at 7:48 AM,  <gobot@golang.org> wrote:
> This CL appears to have broken the netbsd-amd64-bsiegert builder.
> See http://build.golang.org/log/b0722fe3828188c8708c717ff3d7c826042f29f5

I don't think so.