Issue 109370043: Add support for binary payloads to BatchRequest

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 109370043: Add support for binary payloads to BatchRequest (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by wonderfly

Modified:
12 years, 3 months ago

Reviewers:
Anthony Moore, pbaldwin

Base URL:
https://code.google.com/p/google-api-java-client/

Visibility:
Public.

More Reviews

Description

Resolve build warnings of capitalized non-static variable names; Resolve build warnings of not having "@Override" marks for overriden methods; Add support for binary file batching requests; Add tests for binary file batching with protobuf; Add protobuf files for testing.

Patch Set 1 #

Total comments: 2

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+657 lines, -207 lines)			Patch
M	google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/AppIdentityCredential.java	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	google-api-client-appengine/src/test/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/AppIdentityCredentialTest.java	View	6 chunks	+11 lines, -14 lines	0 comments	Download
M	google-api-client/pom.xml	View	2 chunks	+46 lines, -0 lines	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProvider.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/OAuth2Utils.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/batch/BatchUnparsedResponse.java	View	12 chunks	+123 lines, -38 lines	2 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/testing/auth/oauth2/MockTokenServerTransport.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/util/Utils.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/test/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProviderTest.java	View	5 chunks	+17 lines, -13 lines	0 comments	Download
M	google-api-client/src/test/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredentialTest.java	View	13 chunks	+81 lines, -70 lines	0 comments	Download
M	google-api-client/src/test/java/com/google/api/client/googleapis/batch/BatchRequestTest.java	View	26 chunks	+283 lines, -64 lines	0 comments	Download
A	google-api-client/src/test/java/com/google/api/client/googleapis/batch/error_output.proto	View	1 chunk	+76 lines, -0 lines	0 comments	Download
A	google-api-client/src/test/java/com/google/api/client/googleapis/batch/mock_data.proto	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Anthony Moore

12 years, 3 months ago (2014-07-02 18:40:07 UTC) #3

LGTM

Some optional suggestions.

https://codereview.appspot.com/109370043/diff/1/google-api-client/src/main/ja...
File
google-api-client/src/main/java/com/google/api/client/googleapis/batch/BatchUnparsedResponse.java
(right):

https://codereview.appspot.com/109370043/diff/1/google-api-client/src/main/ja...
google-api-client/src/main/java/com/google/api/client/googleapis/batch/BatchUnparsedResponse.java:124:
if ("Content-Length".equalsIgnoreCase(headerName.trim())) {
Would it be better to do the trim when the value is first extracted?

https://codereview.appspot.com/109370043/diff/1/google-api-client/src/main/ja...
google-api-client/src/main/java/com/google/api/client/googleapis/batch/BatchUnparsedResponse.java:163:
} else {
Having an else just to contain a comment seems odd. Could the comment be tweaked
so that the else is not needed?

Expand All Messages | Collapse All Messages