Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1407)

Issue 10935046: issue 3441: banjo example should use Staff + TabStaff (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by fedelogy
Modified:
6 years, 3 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

issue 3441: banjo example should use Staff + TabStaff

Patch Set 1 #

Total comments: 3

Patch Set 2 : StaffGroup and moderntab clef removed to be consistent with rest of documentation, \set and \overriā€¦ #

Patch Set 3 : CG: command to ease the update of snippets' committishes by translators #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M Documentation/contributor/doc-work.itexi View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6
fedelogy
6 years, 4 months ago (2013-07-06 16:47:41 UTC) #1
thomasmorley651
Some thoughts, otherwise LGTM. https://codereview.appspot.com/10935046/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): https://codereview.appspot.com/10935046/diff/1/Documentation/notation/fretted-strings.itely#newcode1864 Documentation/notation/fretted-strings.itely:1864: \override Staff.StringNumber.stencil = ##f I'm ...
6 years, 4 months ago (2013-07-07 19:54:09 UTC) #2
dak
https://codereview.appspot.com/10935046/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): https://codereview.appspot.com/10935046/diff/1/Documentation/notation/fretted-strings.itely#newcode1864 Documentation/notation/fretted-strings.itely:1864: \override Staff.StringNumber.stencil = ##f On 2013/07/07 19:54:09, thomasmorley651 wrote: ...
6 years, 4 months ago (2013-07-07 20:13:32 UTC) #3
fedelogy
StaffGroup and moderntab clef removed to be consistent with rest of documentation, \set and \override ...
6 years, 4 months ago (2013-07-08 06:04:44 UTC) #4
Graham Percival
LGTM
6 years, 4 months ago (2013-07-11 02:39:29 UTC) #5
fedelogy
6 years, 3 months ago (2013-08-04 02:09:42 UTC) #6
CG: command to ease the update of snippets' committishes by translators
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b