Code review - Issue 10935046: issue 3441: banjo example should use Staff + TabStaffhttps://codereview.appspot.com/2013-08-04T02:09:42+00:00rietveld
Message from unknown
2013-07-06T16:24:15+00:00fedelogyurn:md5:9af58454d66cb5bfd3cd92d7d2bf6ea7
Message from fedelogy@gmail.com
2013-07-06T16:47:41+00:00fedelogyurn:md5:6dd6aa2b07d79bbb3c095f0e8018df8c
Message from thomasmorley65@gmail.com
2013-07-07T19:54:09+00:00thomasmorley651urn:md5:88c339effefb9826f50476d68f615f5e
Some thoughts, otherwise LGTM.
https://codereview.appspot.com/10935046/diff/1/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
https://codereview.appspot.com/10935046/diff/1/Documentation/notation/fretted-strings.itely#newcode1864
Documentation/notation/fretted-strings.itely:1864: \override Staff.StringNumber.stencil = ##f
I'm not sure about the \override
It surely looks better.
Though, our policy seems to be to put no \override into the NR, apart from situations where it's necassary.
One might argue it's not.
https://codereview.appspot.com/10935046/diff/1/Documentation/notation/fretted-strings.itely#newcode1870
Documentation/notation/fretted-strings.itely:1870: \new StaffGroup <<
Currently we have several examples with and without \new StaffGroup.
That's not consistent.
IMHO, we should group every \Staff with additional \TabStaff without SystemStartBracket and SpanBar, i.e. omitting \new StaffGroup.
Message from dak@gnu.org
2013-07-07T20:13:32+00:00dakurn:md5:a6d9d1e2a195fa929a18c207e0ab9b5c
https://codereview.appspot.com/10935046/diff/1/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
https://codereview.appspot.com/10935046/diff/1/Documentation/notation/fretted-strings.itely#newcode1864
Documentation/notation/fretted-strings.itely:1864: \override Staff.StringNumber.stencil = ##f
On 2013/07/07 19:54:09, thomasmorley651 wrote:
>
> I'm not sure about the \override
> It surely looks better.
> Though, our policy seems to be to put no \override into the NR, apart from
> situations where it's necassary.
> One might argue it's not.
It makes a difference. At any rate, this is a case where
\omit Staff.StringNumber
would be less obscure.
At any rate, I consider it a mistake to put the sets/overrides into the music. The problem is that they will likely create spurious staffs.
Message from unknown
2013-07-08T06:04:42+00:00fedelogyurn:md5:312f6f953eb68fee224b9cfc043cc5d3
Message from fedelogy@gmail.com
2013-07-08T06:04:44+00:00fedelogyurn:md5:7040ce6902150a577c109386afae8ad7
StaffGroup and moderntab clef removed to be consistent with rest of documentation, \set and \override moved to a \with block
Message from graham@percival-music.ca
2013-07-11T02:39:29+00:00Graham Percivalurn:md5:6d7957805fe26d5fa446170c79df69dd
LGTM
Message from unknown
2013-08-04T02:09:39+00:00fedelogyurn:md5:83ead7412af2e5b7ae221816f2e7497b
Message from fedelogy@gmail.com
2013-08-04T02:09:42+00:00fedelogyurn:md5:a822d80be1ca9e57019533d68c70132f
CG: command to ease the update of snippets' committishes by translators