code review 10932045: cmd/go, testing: remove redundant "for pkg" in coverage...

cmd/go, testing: remove redundant "for pkg" in coverage message

This is a transcript before this change. I've capitalized the text being removed.
Note that it is always near another line that already says fmt, marked with <<<

$ cd $GOROOT/src/pkg/fmt

$ go test -cover
PASS
coverage FOR FMT: 91.3% of statements
ok  	fmt	0.040s <<<

$ go test -coverpkg strconv
PASS
coverage FOR FMT: 64.9% of statements in strconv
ok  	fmt	0.039s <<<

$ go test -cover -c
$ ./fmt.test -test.covermode=set <<<
PASS
coverage FOR FMT: 91.3% of statements

$ go test -coverpkg strconv -c
$ ./fmt.test -test.covermode=set <<<
PASS
coverage FOR FMT: 64.9% of statements in strconv

That the summary printed by 'go test [options] fmt' is unchanged:

$ go test -cover fmt
ok  	fmt	0.040s	coverage: 91.3% of statements

$ go test -coverpkg strconv fmt
ok  	fmt	0.038s	coverage: 64.9% of statements in strconv

[rsc, 2013-07-11 20:43:31]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[gobot, 2013-07-12 04:36:36]

R=r (assigned by dsymonds)

[r, 2013-07-12 04:49:34]

LGTM

I said I was happy with this as it is. Why the urge to change it? But it's
easier to acquiesce than argue.

[rsc, 2013-07-12 04:59:33]

On Fri, Jul 12, 2013 at 12:49 AM, <r@golang.org> wrote:

> LGTM
>
> I said I was happy with this as it is. Why the urge to change it? But
> it's easier to acquiesce than argue.
>

I sent the CL because your reason for keeping it doesn't apply to the
change I am suggesting:

On Tue, Jul 9, 2013 at 7:51 PM, Rob Pike <r@golang.org> wrote:

> If you do something like
>
> go test -coverpkg=strconv fmt
>
> the message is
>
> coverage for fmt: 66.4% of statements in strconv
>
> That's very clear. Dropping the "for fmt" would make it
>
> coverage: 66.4% of statements in strconv
>
> which is OK in context but a little misleading out of context. I like
> the clarity.
>

I tried to address this in my CL description by showing all the possible
contexts. The output of that specific command is unchanged by this CL and
is:

$ go test -coverpkg strconv fmt
ok      fmt     0.038s  coverage: 64.9% of statements in strconv
$

This change only affects the print when the package name is printed on the
next line (during go test with no package argument) or you just ran the
test binary by hand. In fact it makes all the output more regular: you get
exactly the same "coverage: ..." text when running the test by hand that
you do in the 'go test' summary.

Russ

[r, 2013-07-12 05:09:16]

I see. Thanks. In the all the noise I missed that - which is an
argument for making this change.

[rsc, 2013-07-12 11:34:23]

*** Submitted as https://code.google.com/p/go/source/detail?r=fd8dcd53e0ec ***

cmd/go, testing: remove redundant "for pkg" in coverage message

This is a transcript before this change. I've capitalized the text being
removed.
Note that it is always near another line that already says fmt, marked with <<<

$ cd $GOROOT/src/pkg/fmt

$ go test -cover
PASS
coverage FOR FMT: 91.3% of statements
ok  	fmt	0.040s <<<

$ go test -coverpkg strconv
PASS
coverage FOR FMT: 64.9% of statements in strconv
ok  	fmt	0.039s <<<

$ go test -cover -c
$ ./fmt.test -test.covermode=set <<<
PASS
coverage FOR FMT: 91.3% of statements

$ go test -coverpkg strconv -c
$ ./fmt.test -test.covermode=set <<<
PASS
coverage FOR FMT: 64.9% of statements in strconv

That the summary printed by 'go test [options] fmt' is unchanged:

$ go test -cover fmt
ok  	fmt	0.040s	coverage: 91.3% of statements

$ go test -coverpkg strconv fmt
ok  	fmt	0.038s	coverage: 64.9% of statements in strconv

R=r
CC=gobot, golang-dev
https://codereview.appspot.com/10932045