Issue 109220046: code review 109220046: runtime: update arm comments now register m is gone

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 109220046: code review 109220046: runtime: update arm comments now register m is gone (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by crawshaw

Modified:
10 years, 11 months ago

Reviewers:
minux

CC:
golang-codereviews, minux

Visibility:
Public.

Description

runtime: update arm comments now register m is gone

Patch Set 1 #

Patch Set 2 : diff -r 4af9a710ed44 https://code.google.com/p/go #

Patch Set 3 : diff -r 4af9a710ed44 https://code.google.com/p/go #

Patch Set 4 : diff -r 4af9a710ed44 https://code.google.com/p/go #

Patch Set 5 : diff -r 7bdeb1a01252 https://code.google.com/p/go #

Patch Set 6 : diff -r 1fcd603852b0 https://code.google.com/p/go #

Patch Set 7 : diff -r 1fcd603852b0 https://code.google.com/p/go #

Patch Set 8 : diff -r 767350c547a0 https://code.google.com/p/go #

Patch Set 9 : diff -r 767350c547a0 https://code.google.com/p/go #

Patch Set 10 : diff -r 767350c547a0 https://code.google.com/p/go #

Patch Set 11 : diff -r 767350c547a0 https://code.google.com/p/go #

Patch Set 12 : diff -r 767350c547a0 https://code.google.com/p/go #

Patch Set 13 : diff -r 767350c547a0 https://code.google.com/p/go #

Patch Set 14 : diff -r c31a70f2f542 https://code.google.com/p/go #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	src/pkg/runtime/asm_arm.s	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
	M	src/pkg/runtime/cgo/gcc_arm.S	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

crawshaw

Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 11 months ago (2014-06-28 22:56:52 UTC) #1

crawshaw

Found one more comment reference to setmg in cgo/gcc_arm.S. On Sat, Jun 28, 2014 at ...

10 years, 11 months ago (2014-06-28 23:54:29 UTC) #3

crawshaw

10 years, 11 months ago (2014-06-30 23:11:01 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=26db394e3aca ***

runtime: update arm comments now register m is gone

LGTM=minux
R=golang-codereviews, minux
CC=golang-codereviews
https://codereview.appspot.com/109220046

Expand All Messages | Collapse All Messages