code review 109220044: strings: Replacer is safe for concurrent use

strings: Replacer is safe for concurrent use

[eds, 2014-06-26 17:25:36]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2014-06-27 18:26:30]

R=r for words and deciding whether "It" is better here.



On Thu, Jun 26, 2014 at 10:25 AM, <chickencha@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> strings: Replacer is safe for concurrent use
>
> Please review this at https://codereview.appspot.com/109220044/
>
> Affected files (+1, -0 lines):
>   M src/pkg/strings/replace.go
>
>
> Index: src/pkg/strings/replace.go
> ===================================================================
> --- a/src/pkg/strings/replace.go
> +++ b/src/pkg/strings/replace.go
> @@ -2,16 +2,17 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
>  package strings
>
>  import "io"
>
>  // A Replacer replaces a list of strings with replacements.
> +// A Replacer is safe for concurrent use by multiple goroutines.
>  type Replacer struct {
>         r replacer
>  }
>
>  // replacer is the interface that a replacement algorithm needs to
> implement.
>  type replacer interface {
>         Replace(s string) string
>         WriteString(w io.Writer, s string) (n int, err error)
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[r, 2014-06-27 18:34:55]

https://codereview.appspot.com/109220044/diff/30001/src/pkg/strings/replace.go
File src/pkg/strings/replace.go (right):

https://codereview.appspot.com/109220044/diff/30001/src/pkg/strings/replace.g...
src/pkg/strings/replace.go:10: // A Replacer is safe for concurrent use by
multiple goroutines.
s/A Replacer/It/

or
-s/.$//
s/A Replacer/and/

[eds, 2014-06-28 22:47:53]

Hello golang-codereviews@googlegroups.com, bradfitz@golang.org, r@golang.org
(cc: golang-codereviews@googlegroups.com),

Please take another look.

[r, 2014-06-28 22:52:30]

LGTM

[r, 2014-06-28 22:53:18]

*** Submitted as https://code.google.com/p/go/source/detail?r=7bdeb1a01252 ***

strings: Replacer is safe for concurrent use

LGTM=r
R=golang-codereviews, bradfitz, r
CC=golang-codereviews
https://codereview.appspot.com/109220044

Committer: Rob Pike <r@golang.org>

[gobot, 2014-06-28 23:54:58]

This CL appears to have broken the plan9-386-cnielsen builder.
See http://build.golang.org/log/69a7c5f51d0c72d7390aa18a918af31303d6db52