Issue 10917043: code review 10917043: go/parser: accept optional indices for all parts of an ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10917043: code review 10917043: go/parser: accept optional indices for all parts of an ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by gri

Modified:
12 years ago

Reviewers:
adonovan

CC:
adonovan, golang-dev

Visibility:
Public.

Description

go/parser: accept optional indices for all parts of an index expression Instead, leave the error testing to the type checker, eventually. Fixes issue 5827.

Patch Set 1 #

Patch Set 2 : diff -r bb98e4c9b6b3 https://code.google.com/p/go #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -10 lines)			Patch
	M	src/pkg/go/parser/parser.go	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	src/pkg/go/parser/short_test.go	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello adonovan (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years ago (2013-07-03 17:40:21 UTC) #1

adonovan

On 2013/07/03 17:40:21, gri wrote: > Hello adonovan (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...

12 years ago (2013-07-03 17:42:31 UTC) #2

gri

12 years ago (2013-07-03 17:43:29 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=84917868ef43 ***

go/parser: accept optional indices for all parts of an index expression

Instead, leave the error testing to the type checker, eventually.

Fixes issue 5827.

R=adonovan
CC=golang-dev
https://codereview.appspot.com/10917043

Expand All Messages | Collapse All Messages