Issue 109170043: code review 109170043: strings: additional tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 109170043: code review 109170043: strings: additional tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by dave

Modified:
10 years, 11 months ago

Reviewers:
ruiu, r

CC:
ruiu, r, golang-codereviews

Visibility:
Public.

Description

strings: additional tests This CL re-applies the tests added in CL 101330053 and subsequently rolled back in CL 102610043. The original author of this change was Rui Ueyama <ruiu@google.com>

Patch Set 1 #

Patch Set 2 : diff -r 75040398cb4e https://code.google.com/p/go #

Patch Set 3 : diff -r 75040398cb4e https://code.google.com/p/go #

Patch Set 4 : diff -r 829d3df73b1a https://code.google.com/p/go #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -12 lines)			Patch
	M	src/pkg/strings/replace_test.go	View	1	2 chunks	+30 lines, -12 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello ruiu@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 11 months ago (2014-06-24 10:12:42 UTC) #1

dave_cheney.net

10 years, 11 months ago (2014-06-24 17:06:36 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=b3702180c491 ***

strings: additional tests

This CL re-applies the tests added in CL 101330053 and subsequently rolled back
in CL 102610043.

The original author of this change was Rui Ueyama <ruiu@google.com>

LGTM=r, ruiu
R=ruiu, r
CC=golang-codereviews
https://codereview.appspot.com/109170043

Expand All Messages | Collapse All Messages