Issue 10914045: code review 10914045: misc/cgo/test: skip test for issue 3250, the runtime is...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10914045: code review 10914045: misc/cgo/test: skip test for issue 3250, the runtime is... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by minux1

Modified:
12 years, 11 months ago

Reviewers:
iant

CC:
golang-dev, iant

Visibility:
Public.

Description

misc/cgo/test: skip test for issue 3250, the runtime isn't ready yet. see issue 5885.

Patch Set 1 #

Patch Set 2 : diff -r e8b145221231 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 58ee92a528da https://code.google.com/p/go/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	misc/cgo/test/issue3250.go	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 11 months ago (2013-07-14 19:22:19 UTC) #1

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 11 months ago (2013-07-14 19:23:05 UTC) #2

minux1

12 years, 11 months ago (2013-07-15 06:37:49 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=61b8f10038ed ***

misc/cgo/test: skip test for issue 3250, the runtime isn't ready yet.
see issue 5885.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/10914045

Expand All Messages | Collapse All Messages