Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(82)

Issue 10914045: code review 10914045: misc/cgo/test: skip test for issue 3250, the runtime is... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by minux1
Modified:
12 years, 11 months ago
Reviewers:
iant
CC:
golang-dev, iant
Visibility:
Public.

Description

misc/cgo/test: skip test for issue 3250, the runtime isn't ready yet. see issue 5885.

Patch Set 1 #

Patch Set 2 : diff -r e8b145221231 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 58ee92a528da https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M misc/cgo/test/issue3250.go View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
minux1
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
12 years, 11 months ago (2013-07-14 19:22:19 UTC) #1
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 11 months ago (2013-07-14 19:23:05 UTC) #2
iant
LGTM Sigh.
12 years, 11 months ago (2013-07-14 21:16:32 UTC) #3
minux1
12 years, 11 months ago (2013-07-15 06:37:49 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=61b8f10038ed ***

misc/cgo/test: skip test for issue 3250, the runtime isn't ready yet.
see issue 5885.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/10914045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b