Issue 109090048: code review 109090048: strings: define byteBitmap.isSet

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 109090048: code review 109090048: strings: define byteBitmap.isSet (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 12 months ago by ruiu

Modified:
10 years, 12 months ago

Reviewers:
dave

CC:
golang-codereviews, bradfitz, dave_cheney.net

Visibility:
Public.

Description

strings: define byteBitmap.isSet

Patch Set 1 #

Patch Set 2 : diff -r d602aea40896 https://code.google.com/p/go #

Patch Set 3 : diff -r 5df696558635 https://code.google.com/p/go #

Patch Set 4 : diff -r 5df696558635 https://code.google.com/p/go #

Patch Set 5 : diff -r 5df696558635 https://code.google.com/p/go #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
	M	src/pkg/strings/replace.go	View	1	8 chunks	+11 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ruiu

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 12 months ago (2014-06-20 02:25:54 UTC) #1

ruiu

Hello golang-codereviews@googlegroups.com, bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.

10 years, 12 months ago (2014-06-20 02:26:39 UTC) #2

ruiu

10 years, 12 months ago (2014-06-20 03:10:59 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=69b3f42e1c4d ***

strings: define byteBitmap.isSet

LGTM=dave
R=golang-codereviews, bradfitz, dave
CC=golang-codereviews
https://codereview.appspot.com/109090048

Expand All Messages | Collapse All Messages