Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(268)

Issue 10907043: code review 10907043: cmd/go: fix "go get -u" for git repositories. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by minux1
Modified:
11 years, 12 months ago
Reviewers:
dsymonds
CC:
dsymonds, golang-dev
Visibility:
Public.

Description

cmd/go: fix "go get -u" for git repositories. CL 10869046 changed cmd/go to checkout master branch, so for "go get -u" to work, it must "git pull" instead of "git fetch". Added "--ff-only" so that it won't accidentally overwrite user changes.

Patch Set 1 #

Patch Set 2 : diff -r bb98e4c9b6b3 https://code.google.com/p/go/ #

Patch Set 3 : diff -r bb98e4c9b6b3 https://code.google.com/p/go/ #

Patch Set 4 : diff -r cf792c00f410 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/go/vcs.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
minux1
Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years ago (2013-07-03 09:36:55 UTC) #1
dsymonds
LGTM but sit on it for a day in case there are objections.
12 years ago (2013-07-03 10:31:06 UTC) #2
minux1
11 years, 12 months ago (2013-07-07 15:06:44 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=fc06b300732a ***

cmd/go: fix "go get -u" for git repositories.
CL 10869046 changed cmd/go to checkout master branch, so
for "go get -u" to work, it must "git pull" instead of
"git fetch". Added "--ff-only" so that it won't accidentally
overwrite user changes.

R=dsymonds
CC=golang-dev
https://codereview.appspot.com/10907043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b