Issue 10906043: state: Rename EntityWatcher to NotifyWatcher

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10906043: state: Rename EntityWatcher to NotifyWatcher

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by jameinel

Modified:
10 years, 10 months ago

Reviewers:
gz, mp+172769, fwereade

Visibility:
Public.

Description

state: Rename EntityWatcher to NotifyWatcher William and I agree that NotifyWatcher is a better name. Let's fix the name before we are stuff with lots of API calls using a different name. I think this is still safe because the APIs exposing this name are all newly introduced in 1.11. https://code.launchpad.net/~jameinel/juju-core/notify-watcher/+merge/172769 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: Rename EntityWatcher to NotifyWatcher #

Total comments: 2

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -53 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	doc/api.txt	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	doc/hacking-state.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	state/api/params/params.go	View		2 chunks	+9 lines, -9 lines	1 comment	Download
M	state/api/watcher.go	View		4 chunks	+7 lines, -7 lines	0 comments	Download
M	state/apiserver/machine/machiner.go	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	state/apiserver/machine/machiner_test.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	state/apiserver/root.go	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	state/apiserver/watcher.go	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	state/state_test.go	View		1 chunk	+1 line, -1 line	1 comment	Download
M	state/watcher.go	View	1	7 chunks	+20 lines, -12 lines	0 comments	Download
M	worker/uniter/filter.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

fwereade

I think it's nicest to make state.NotifyWatcher an interface (rather less API boilerplate then I ...

10 years, 10 months ago (2013-07-03 09:26:12 UTC) #2

fwereade

LGTM https://codereview.appspot.com/10906043/diff/5001/state/state_test.go File state/state_test.go (right): https://codereview.appspot.com/10906043/diff/5001/state/state_test.go#newcode1064 state/state_test.go:1064: // TODO(fwereade) just use an NotifyWatcher and NotifyWatcherC ...

10 years, 10 months ago (2013-07-03 10:17:44 UTC) #4

10 years, 10 months ago (2013-07-03 11:23:14 UTC) #5

LGTM

https://codereview.appspot.com/10906043/diff/5001/state/api/params/params.go
File state/api/params/params.go (right):

https://codereview.appspot.com/10906043/diff/5001/state/api/params/params.go#...
state/api/params/params.go:70: // returning a list of Entity Watchers
...a list of NotifyWatcher? Or something

Expand All Messages | Collapse All Messages