Visual update #2

Visual update #2

This completes the work from lp:~rharding/juju-gui/new-controls and lp:~huwshimi/juju-gui/visual-update-1 in adding the new header and making it work.

https://code.launchpad.net/~huwshimi/juju-gui/visual-update-2/+merge/172739

Requires: https://code.launchpad.net/~rharding/juju-gui/new-controls/+merge/172631

(do not edit description out of merge proposal)

[huwshimi, 2013-07-03 06:45:20]

Please take a look.

[rharding, 2013-07-03 13:19:39]

I don't follow this change. It adds a regression where the show/hide icon
doesn't move. It appears the change is centered around moving the bws-icon to
other templates and trying to add the concept of content-visible css class. The
issue is that you're hooking this class up into if the details of a charm is
visible which can be true/false which the sidebar or fullscreen (.charmbrowser)
is always there. I'm not following why they've been associated.

[huwshimi, 2013-07-03 22:58:59]

On 2013/07/03 13:19:39, rharding wrote:
> I don't follow this change. It adds a regression where the show/hide icon
> doesn't move. It appears the change is centered around moving the bws-icon to
> other templates and trying to add the concept of content-visible css class.
The
> issue is that you're hooking this class up into if the details of a charm is
> visible which can be true/false which the sidebar or fullscreen
(.charmbrowser)
> is always there. I'm not following why they've been associated.

The positioning bug was caused by the code for small screen sizes not accounting
for the minimised browser. I've pushed a change for that and additionally makes
the icon orange when the sidebar is minimised.

[huwshimi, 2013-07-04 00:05:36]

Please take a look.

[gary.poster, 2013-07-04 00:12:16]

LGTM.  Thank you!

The diff is crazy on rietveld but looks good locally.

[huwshimi, 2013-07-04 00:22:26]

*** Submitted:

Visual update #2

This completes the work from lp:~rharding/juju-gui/new-controls and
lp:~huwshimi/juju-gui/visual-update-1 in adding the new header and making it
work.

R=rharding, gary.poster
CC=
https://codereview.appspot.com/10904043