Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(63)

Issue 10902044: Update visual design #1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by huwshimi
Modified:
10 years, 10 months ago
Reviewers:
rharding, benji, mp+172738
Visibility:
Public.

Description

Update visual design #1 This branch implements the new header and adds the beginnings of the new visual design for the sidebar. It has two followup branches that should be landed as part of this work (lp:~rharding/juju-gui/new-controls and lp:~huwshimi/juju-gui/visual-update-2) otherwise the new header nav will not work and there will be a couple of visual glitches. https://code.launchpad.net/~huwshimi/juju-gui/visual-update-1/+merge/172738 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -218 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/assets/images/browser_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/browser_searchbox_delete_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/assets/images/browser_searchbox_search_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/assets/images/juju_logo_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/index.html View 2 chunks +10 lines, -6 lines 0 comments Download
M app/subapps/browser/templates/minimized.handlebars View 1 chunk +11 lines, -2 lines 0 comments Download
M app/templates/browser-search.handlebars View 1 chunk +3 lines, -22 lines 0 comments Download
A app/templates/bws-searchbox.partial View 1 chunk +12 lines, -0 lines 0 comments Download
M app/widgets/charm-search.js View 1 chunk +0 lines, -21 lines 0 comments Download
M lib/views/browser/browser-icon.less View 1 chunk +11 lines, -11 lines 0 comments Download
A lib/views/browser/bws-searchbox.less View 1 chunk +35 lines, -0 lines 0 comments Download
M lib/views/browser/charm-container.less View 1 chunk +0 lines, -3 lines 0 comments Download
M lib/views/browser/charm-token.less View 1 chunk +4 lines, -3 lines 0 comments Download
M lib/views/browser/main.less View 5 chunks +25 lines, -94 lines 0 comments Download
M lib/views/browser/minimized.less View 1 chunk +4 lines, -11 lines 0 comments Download
M lib/views/browser/section-title.less View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/views/browser/vars.less View 1 chunk +8 lines, -2 lines 0 comments Download
M lib/views/stylesheet.less View 8 chunks +65 lines, -30 lines 2 comments Download
M test/test_browser_search_widget.js View 2 chunks +1 line, -14 lines 0 comments Download

Messages

Total messages: 4
huwshimi
Please take a look.
10 years, 10 months ago (2013-07-03 06:44:21 UTC) #1
rharding
LGTM with the conditional notes in as this is one branch in a series to ...
10 years, 10 months ago (2013-07-03 12:07:45 UTC) #2
benji
LGTM with some small notes. https://codereview.appspot.com/10902044/diff/1/lib/views/stylesheet.less File lib/views/stylesheet.less (right): https://codereview.appspot.com/10902044/diff/1/lib/views/stylesheet.less#newcode237 lib/views/stylesheet.less:237: // Need to subtract ...
10 years, 10 months ago (2013-07-03 12:24:45 UTC) #3
huwshimi
10 years, 10 months ago (2013-07-03 22:25:17 UTC) #4
Thanks both of you. Benji, I think I'll clean those two up in a subsequent
branch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b