code review 10895043: go.tools/cmd/vet: improvements to static checking of pr...

go.tools/cmd/vet: improvements to static checking of printf calls.

Details:
- added support for complex numbers as distinct from floats:
  %[efg] allows complex; %b does not.
- %p: only Signature, Map, Chan, Slice, unsafe.Pointer allowed.
- %s: allow []byte.
- allow a verb to match map[K]V and []T if it matches K/V/T,
  e.g. %d now matches []int.  i.e. matching is recursive.
- use go/types' constant folding.  literal() is gone.
- group cases together.

Added tests.

[adonovan, 2013-07-02 22:26:37]

Hello gri@golang.org, r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools

[r, 2013-07-03 02:04:01]

I assure you vet uses go/types:

% cd go.tools/cmd/vet
/Users/r/src/code.google.com/p/go.tools/cmd/vet
% g go.types
main.go:25: "code.google.com/p/go.tools/go/types"
shadow.go:37: "code.google.com/p/go.tools/go/types"
types.go:5: // This file contains the pieces of the tool that use
typechecking from the go/types package.
types.go:14: "code.google.com/p/go.tools/go/types"
types.go:73: // TODO: Simplify when we have the IsAssignableTo
predicate in go/types.
%

-rob

[adonovan, 2013-07-03 14:43:15]

D'oh.




On 2 July 2013 22:03, Rob Pike <r@golang.org> wrote:

> I assure you vet uses go/types:
>
> % cd go.tools/cmd/vet
> /Users/r/src/code.google.com/p/go.tools/cmd/vet
> % g go.types
> main.go:25: "code.google.com/p/go.tools/go/types"
> shadow.go:37: "code.google.com/p/go.tools/go/types"
> types.go:5: // This file contains the pieces of the tool that use
> typechecking from the go/types package.
> types.go:14: "code.google.com/p/go.tools/go/types"
> types.go:73: // TODO: Simplify when we have the IsAssignableTo
> predicate in go/types.
> %
>
> -rob
>

[adonovan, 2013-07-10 15:25:01]

Hello gri@golang.org, r@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2013-07-12 04:43:54]

let's land 10748044 and 11206043 and then update this.

-rob


On Thu, Jul 11, 2013 at 1:25 AM,  <adonovan@google.com> wrote:
> Hello gri@golang.org, r@golang.org (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
> https://codereview.appspot.com/10895043/

[adonovan, 2013-07-12 18:16:39]

Hello gri@golang.org, r@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2013-07-12 21:54:26]

looks good but it needs a tweak after the recent submissions. you'll probably
have a conflict when you hg sync

[r, 2013-07-12 22:16:31]

CL description needs updating too

[adonovan, 2013-07-15 17:40:35]

Hello gri@golang.org, r@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[adonovan, 2013-07-15 17:41:15]

On 2013/07/12 22:16:31, r wrote:
> CL description needs updating too

Done; PTAL.

(Was it just coincidence that your CL fixed the same bug as in the first draft
of this CL?)

[r, 2013-07-15 22:07:00]

total coincidence.

-rob

[r, 2013-07-15 22:08:51]

LGTM

https://codereview.appspot.com/10895043/diff/51001/cmd/vet/types.go
File cmd/vet/types.go (right):

https://codereview.appspot.com/10895043/diff/51001/cmd/vet/types.go#newcode72
cmd/vet/types.go:72: // matchArgType reports an error if printf verb t is
inappropriate for
s/inappropriate/appropriate/

https://codereview.appspot.com/10895043/diff/51001/cmd/vet/types.go#newcode78
cmd/vet/types.go:78: // may be printed with %d etc if this is appropriate for
their element
s/etc/&./
s/this/that/

[adonovan, 2013-07-15 22:37:53]

*** Submitted as
https://code.google.com/p/go/source/detail?r=9f7367db9db0&repo=tools ***

go.tools/cmd/vet: improvements to static checking of printf calls.

Details:
- added support for complex numbers as distinct from floats:
  %[efg] allows complex; %b does not.
- %p: only Signature, Map, Chan, Slice, unsafe.Pointer allowed.
- %s: allow []byte.
- allow a verb to match map[K]V and []T if it matches K/V/T,
  e.g. %d now matches []int.  i.e. matching is recursive.
- use go/types' constant folding.  literal() is gone.
- group cases together.

Added tests.

R=gri, r
CC=golang-dev
https://codereview.appspot.com/10895043

[adonovan, 2013-07-25 20:43:20]

*** Abandoned ***