Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 108940044: Handle empty JSON token response errors.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by wonderfly
Modified:
9 years, 10 months ago
Reviewers:
Anthony Moore
CC:
jkolhe_google.com
Base URL:
https://code.google.com/p/google-oauth-java-client/
Visibility:
Public.

Description

Handle empty JSON token response errors. Issue 96: https://code.google.com/p/google-oauth-java-client/issues/detail?id=96

Patch Set 1 #

Total comments: 1

Messages

Total messages: 2
wonderfly
9 years, 10 months ago (2014-06-12 21:01:07 UTC) #1
Anthony Moore
9 years, 10 months ago (2014-06-12 23:31:08 UTC) #2
I want to check first if we can solve this without the new virtual method.

https://codereview.appspot.com/108940044/diff/1/google-oauth-client/src/main/...
File
google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/CredentialRefreshListener.java
(right):

https://codereview.appspot.com/108940044/diff/1/google-oauth-client/src/main/...
google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/CredentialRefreshListener.java:86:
void onTokenErrorResponse(Credential credential, String tokenErrorResponse)
So, this feels like a disruptive and potentially breaking change that may be
disproportional for fixing a null reference error. It would be better to avoid
introducing new virtual methods here. Would it be possible to new up a dummy
TokenErrorResponse in this case so it can go through the original virtual call
instead?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b