Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(321)

Issue 10889044: Rough TicketIndex implementation

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months, 2 weeks ago by xiaq
Modified:
9 months ago
Reviewers:
thomas.j.waldmann, ThomasWaldmann, evgsyr
Visibility:
Public.

Description

Rough TicketIndex implementation

Patch Set 1 : #

Patch Set 2 : change ticket/index.html indent #

Patch Set 3 : ticket/index.html: add an id to the <table>, use <thead> and <tbody> #

Total comments: 14

Patch Set 4 : reorganize code, address issues #

Patch Set 5 : ticket.py: index_fields renamed to display_fields and moved (its content untouched) #

Patch Set 6 : remove an unused import #

Total comments: 1

Patch Set 7 : put display_fields.py under a new schema package #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -3 lines) Patch
A MoinMoin/constants/display_widgets.py View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M MoinMoin/items/ticket.py View 1 2 3 4 5 6 3 chunks +49 lines, -3 lines 0 comments Download
A MoinMoin/schema/__init__.py View 1 2 3 4 5 6 1 chunk +20 lines, -0 lines 0 comments Download
A MoinMoin/schema/display.py View 1 2 3 4 5 6 1 chunk +22 lines, -0 lines 0 comments Download
A MoinMoin/templates/display_widgets.html View 1 2 3 1 chunk +39 lines, -0 lines 0 comments Download
A MoinMoin/templates/ticket/index.html View 1 2 3 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 7
xiaq
plz review this! :)
9 months, 2 weeks ago #1
Thomas.J.Waldmann
https://codereview.appspot.com/10889044/diff/10001/MoinMoin/items/ticket.py File MoinMoin/items/ticket.py (right): https://codereview.appspot.com/10889044/diff/10001/MoinMoin/items/ticket.py#newcode203 MoinMoin/items/ticket.py:203: description = L_('An index for all tickets under it') ...
9 months, 1 week ago #2
xiaq
https://codereview.appspot.com/10889044/diff/10001/MoinMoin/items/ticket.py File MoinMoin/items/ticket.py (right): https://codereview.appspot.com/10889044/diff/10001/MoinMoin/items/ticket.py#newcode203 MoinMoin/items/ticket.py:203: description = L_('An index for all tickets under it') ...
9 months, 1 week ago #3
xiaq
https://codereview.appspot.com/10889044/diff/10001/MoinMoin/util/itemfields.py File MoinMoin/util/itemfields.py (right): https://codereview.appspot.com/10889044/diff/10001/MoinMoin/util/itemfields.py#newcode15 MoinMoin/util/itemfields.py:15: pass On 2013/07/12 01:31:22, xiaq wrote: > On 2013/07/11 ...
9 months, 1 week ago #4
Thomas.J.Waldmann
https://codereview.appspot.com/10889044/diff/10001/MoinMoin/items/ticket.py File MoinMoin/items/ticket.py (right): https://codereview.appspot.com/10889044/diff/10001/MoinMoin/items/ticket.py#newcode223 MoinMoin/items/ticket.py:223: ) in some cases this would make sense, if ...
9 months, 1 week ago #5
xiaq
https://codereview.appspot.com/10889044/diff/10001/MoinMoin/items/ticket.py File MoinMoin/items/ticket.py (right): https://codereview.appspot.com/10889044/diff/10001/MoinMoin/items/ticket.py#newcode223 MoinMoin/items/ticket.py:223: ) On 2013/07/13 14:40:58, Thomas.J.Waldmann wrote: > in some ...
9 months, 1 week ago #6
Thomas.J.Waldmann
9 months ago #7
https://codereview.appspot.com/10889044/diff/42001/MoinMoin/items/ticket.py
File MoinMoin/items/ticket.py (right):

https://codereview.appspot.com/10889044/diff/42001/MoinMoin/items/ticket.py#n...
MoinMoin/items/ticket.py:30: from MoinMoin.display_field import DisplayField
maybe don't put it into the toplevel package
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5