Issue 108850044: Resolve port conflicts for cf-cloud-controller

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 108850044: Resolve port conflicts for cf-cloud-controller

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by johnsca

Modified:
9 years, 10 months ago

Reviewers:
benjamin.saller, mp+222668

Visibility:
Public.

Description

Resolve port conflicts for cf-cloud-controller https://code.launchpad.net/~johnsca/charms/trusty/cf-cloud-controller/port-conflicts/+merge/222668 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Resolve port conflicts for cf-cloud-controller #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+135 lines, -76 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	hooks/cc-relation-changed	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	hooks/charmhelpers/contrib/cloudfoundry/contexts.py	View	3 chunks	+17 lines, -6 lines	0 comments	Download
M	hooks/charmhelpers/core/services.py	View	4 chunks	+81 lines, -55 lines	0 comments	Download
M	hooks/config.py	View	1 chunk	+11 lines, -1 line	0 comments	Download
M	metadata.yaml	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	templates/cloud_controller.yml	View	3 chunks	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

benjamin.saller

LGTM still wondering if we want to standardize the relation-set call but I'm not sure/

9 years, 10 months ago (2014-06-11 22:47:15 UTC) #2

johnsca

9 years, 10 months ago (2014-06-12 18:04:28 UTC) #3

*** Submitted:

Resolve port conflicts for cf-cloud-controller

R=benjamin.saller
CC=
https://codereview.appspot.com/108850044

Expand All Messages | Collapse All Messages