Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 108840044: Fill out the HM9000 implementation

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by johnsca
Modified:
8 years ago
Reviewers:
benjamin.saller, mp+222673
Visibility:
Public.

Description

Fill out the HM9000 implementation https://code.launchpad.net/~johnsca/charms/trusty/cf-hm9000/port-conflicts/+merge/222673 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fill out the HM9000 implementation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1089 lines, -885 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
D files/README.md View 1 chunk +0 lines, -3 lines 0 comments Download
D files/default-config.json View 1 chunk +0 lines, -27 lines 0 comments Download
A files/hm9000 View 0 chunks +-1 lines, --1 lines 0 comments Download
D files/hm9000.json.erb View 1 chunk +0 lines, -30 lines 0 comments Download
D files/hm9000_analyzer_ctl View 1 chunk +0 lines, -41 lines 0 comments Download
D files/hm9000_api_server_ctl View 1 chunk +0 lines, -40 lines 0 comments Download
D files/hm9000_evacuator_ctl View 1 chunk +0 lines, -40 lines 0 comments Download
D files/hm9000_fetcher_ctl View 1 chunk +0 lines, -41 lines 0 comments Download
D files/hm9000_listener_ctl View 1 chunk +0 lines, -44 lines 0 comments Download
D files/hm9000_metrics_server_ctl View 1 chunk +0 lines, -40 lines 0 comments Download
D files/hm9000_sender_ctl View 1 chunk +0 lines, -41 lines 0 comments Download
D files/hm9000_shredder_ctl View 1 chunk +0 lines, -41 lines 0 comments Download
D files/syslog_forwarder.conf.erb View 1 chunk +0 lines, -65 lines 0 comments Download
A hooks/cc-relation-changed View 1 chunk +5 lines, -0 lines 0 comments Download
M hooks/charmhelpers/contrib/cloudfoundry/common.py View 2 chunks +0 lines, -57 lines 0 comments Download
D hooks/charmhelpers/contrib/cloudfoundry/config_helper.py View 1 chunk +0 lines, -11 lines 0 comments Download
M hooks/charmhelpers/contrib/cloudfoundry/contexts.py View 1 chunk +64 lines, -59 lines 0 comments Download
D hooks/charmhelpers/contrib/cloudfoundry/install.py View 1 chunk +0 lines, -35 lines 0 comments Download
D hooks/charmhelpers/contrib/cloudfoundry/services.py View 1 chunk +0 lines, -118 lines 0 comments Download
D hooks/charmhelpers/contrib/cloudfoundry/upstart_helper.py View 1 chunk +0 lines, -14 lines 0 comments Download
M hooks/charmhelpers/contrib/openstack/context.py View 1 chunk +1 line, -1 line 0 comments Download
M hooks/charmhelpers/contrib/openstack/neutron.py View 1 chunk +17 lines, -1 line 0 comments Download
M hooks/charmhelpers/contrib/openstack/utils.py View 2 chunks +6 lines, -1 line 0 comments Download
M hooks/charmhelpers/contrib/storage/linux/lvm.py View 1 chunk +1 line, -1 line 0 comments Download
M hooks/charmhelpers/contrib/storage/linux/utils.py View 3 chunks +19 lines, -5 lines 0 comments Download
M hooks/charmhelpers/core/hookenv.py View 2 chunks +98 lines, -1 line 0 comments Download
M hooks/charmhelpers/core/host.py View 4 chunks +52 lines, -0 lines 0 comments Download
A hooks/charmhelpers/core/services.py View 1 chunk +347 lines, -0 lines 0 comments Download
A hooks/charmhelpers/core/templating.py View 1 chunk +51 lines, -0 lines 0 comments Download
M hooks/charmhelpers/fetch/__init__.py View 11 chunks +96 lines, -64 lines 0 comments Download
A hooks/config.py View 1 chunk +80 lines, -0 lines 0 comments Download
M hooks/config-changed View 1 chunk +5 lines, -2 lines 0 comments Download
A hooks/etcd-relation-changed View 1 chunk +5 lines, -0 lines 0 comments Download
M hooks/install View 1 chunk +43 lines, -8 lines 0 comments Download
A hooks/metrics-relation-changed View 1 chunk +5 lines, -0 lines 0 comments Download
A hooks/nats-relation-changed View 1 chunk +5 lines, -0 lines 0 comments Download
D hooks/relation-name-relation-broken View 1 chunk +0 lines, -2 lines 0 comments Download
D hooks/relation-name-relation-changed View 1 chunk +0 lines, -9 lines 0 comments Download
D hooks/relation-name-relation-departed View 1 chunk +0 lines, -5 lines 0 comments Download
D hooks/relation-name-relation-joined View 1 chunk +0 lines, -5 lines 0 comments Download
M hooks/start View 1 chunk +5 lines, -4 lines 0 comments Download
M hooks/stop View 1 chunk +5 lines, -7 lines 0 comments Download
M hooks/upgrade-charm View 1 chunk +5 lines, -6 lines 0 comments Download
M metadata.yaml View 2 chunks +6 lines, -9 lines 0 comments Download
D notes.md View 1 chunk +0 lines, -8 lines 0 comments Download
A templates/cf-hm9k-analyzer.conf View 1 chunk +17 lines, -0 lines 0 comments Download
A templates/cf-hm9k-api-server.conf View 1 chunk +17 lines, -0 lines 0 comments Download
A templates/cf-hm9k-evacuator.conf View 1 chunk +17 lines, -0 lines 0 comments Download
A templates/cf-hm9k-fetcher.conf View 1 chunk +17 lines, -0 lines 0 comments Download
A templates/cf-hm9k-listener.conf View 1 chunk +17 lines, -0 lines 0 comments Download
A templates/cf-hm9k-metrics-server.conf View 1 chunk +17 lines, -0 lines 0 comments Download
A templates/cf-hm9k-sender.conf View 1 chunk +17 lines, -0 lines 0 comments Download
A templates/cf-hm9k-shredder.conf View 1 chunk +17 lines, -0 lines 0 comments Download
A templates/hm9000.json View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 5
johnsca
Please take a look.
8 years ago (2014-06-10 15:56:53 UTC) #1
benjamin.saller
T https://codereview.appspot.com/108840044/diff/1/templates/hm9000.json File templates/hm9000.json (right): https://codereview.appspot.com/108840044/diff/1/templates/hm9000.json#newcode20 templates/hm9000.json:20: "metrics_server_user": "metrics_server_user", things like this (user/passwd) still exist ...
8 years ago (2014-06-11 22:41:37 UTC) #2
benjamin.saller
Thanks for this, LGTM we still need this merged into the bundle.
8 years ago (2014-06-11 22:42:00 UTC) #3
johnsca
On 2014/06/11 22:42:00, benjamin.saller wrote: > Thanks for this, LGTM > > we still need ...
8 years ago (2014-06-12 14:12:08 UTC) #4
johnsca
8 years ago (2014-06-12 18:14:48 UTC) #5
*** Submitted:

Fill out the HM9000 implementation

R=benjamin.saller
CC=
https://codereview.appspot.com/108840044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b