Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(310)

Issue 10877043: Break up the search widget to work with updated UX

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by rharding
Modified:
10 years, 10 months ago
Reviewers:
curtis, mp+172631
Visibility:
Public.

Description

Break up the search widget to work with updated UX - Split up the viewmode controls from the search widget itself. - Update the viewmode controls widget to handle distinct fullscreen/sidebar events vs a toggle event - Update the tests to work with both widgets properly. This branch does not update the minimized search to work correctly in the grand scheme of things yet. https://code.launchpad.net/~rharding/juju-gui/new-controls/+merge/172631 Requires: https://code.launchpad.net/~huwshimi/juju-gui/visual-update-1/+merge/172738 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Break up the search widget to work with updated UX #

Unified diffs Side-by-side diffs Delta from patch set Stats (+367 lines, -121 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/index.html View 1 chunk +6 lines, -4 lines 0 comments Download
M app/modules-debug.js View 1 chunk +4 lines, -0 lines 0 comments Download
M app/subapps/browser/views/view.js View 4 chunks +43 lines, -19 lines 0 comments Download
M app/templates/browser-search.handlebars View 1 chunk +0 lines, -1 line 0 comments Download
M app/widgets/charm-search.js View 1 5 chunks +3 lines, -49 lines 0 comments Download
A app/widgets/viewmode-controls.js View 1 1 chunk +170 lines, -0 lines 0 comments Download
M lib/views/browser/main.less View 1 1 chunk +0 lines, -15 lines 0 comments Download
M lib/views/stylesheet.less View 1 1 chunk +20 lines, -0 lines 0 comments Download
M test/index.html View 1 chunk +1 line, -0 lines 0 comments Download
M test/test_browser_app.js View 2 chunks +18 lines, -5 lines 0 comments Download
M test/test_browser_search_widget.js View 2 chunks +1 line, -28 lines 0 comments Download
A test/test_viewmode_controls_widget.js View 1 chunk +99 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rharding
Please take a look.
10 years, 10 months ago (2013-07-02 17:39:22 UTC) #1
curtis
Thank you Rick. These changes LGTM with the additional changes that I can see are ...
10 years, 10 months ago (2013-07-02 18:28:16 UTC) #2
rharding
10 years, 10 months ago (2013-07-03 12:50:02 UTC) #3
*** Submitted:

Break up the search widget to work with updated UX

- Split up the viewmode controls from the search widget itself.
- Update the viewmode controls widget to handle distinct fullscreen/sidebar
events vs a toggle event
- Update the tests to work with both widgets properly. 


This branch does not update the minimized search to work correctly in the grand
scheme of things yet.

R=curtis
CC=
https://codereview.appspot.com/10877043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b