Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1937)

Issue 10876048: worker/cleaner: use new NotifyWorker structure

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by jameinel
Modified:
10 years, 8 months ago
Reviewers:
mue, mp+173357, dfc, fwereade
Visibility:
Public.

Description

worker/cleaner: use new NotifyWorker structure Just reimplements the Cleaner worker as a WatchHandler passed to the NotifyWorker. Cleaner was pretty simple, but I'm still able to remove about 20 lines of boilerplate. (And replace it with heavily tested logic.) https://code.launchpad.net/~jameinel/juju-core/use-notify-worker/+merge/173357 Requires: https://code.launchpad.net/~jameinel/juju-core/notify-worker/+merge/173354 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : worker/cleaner: use new NotifyWorker structure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -43 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M worker/cleaner/cleaner.go View 1 1 chunk +21 lines, -42 lines 0 comments Download
M worker/cleaner/cleaner_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
jameinel
Please take a look.
10 years, 8 months ago (2013-07-07 14:07:39 UTC) #1
dfc
On 2013/07/07 14:07:39, jameinel wrote: > Please take a look. LGTM.
10 years, 8 months ago (2013-07-08 02:02:28 UTC) #2
mue
LGTM, cute, looks much nicer now.
10 years, 8 months ago (2013-07-08 08:59:32 UTC) #3
fwereade
Awesome. LGTM.
10 years, 8 months ago (2013-07-08 09:56:27 UTC) #4
jameinel
10 years, 8 months ago (2013-07-08 11:15:37 UTC) #5
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b