Issue 10876044: Mis-aligned relation with DnD services

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10876044: Mis-aligned relation with DnD services

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by matthew.scott

Modified:
10 years, 10 months ago

Reviewers:
mp+172632, jeff.pihach, benji

Visibility:
Public.

Description

Mis-aligned relation with DnD services Dropped services were missing the 'dragged' attribute, which informs the code the deploys them that they have been intentionally placed, and thus their x/y coords need to be stored in annotations. The behavior seen was a result of the service box having .x and .y set, but not .annotations['gui-x'] and .annotations['gui-y']. The attribute 'dragged' is now renamed to 'hasBeenPositioned', and tests added. https://code.launchpad.net/~makyo/juju-gui/rel-fix-2/+merge/172632 (do not edit description out of merge proposal)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -7 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/charm-panel.js	View	1 2 3	2 chunks	+4 lines, -1 line	0 comments	Download
M	app/views/ghost-inspector.js	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	app/views/topology/service.js	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/test_charm_panel.js	View	1 2 3	3 chunks	+17 lines, -3 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

matthew.scott

10 years, 10 months ago (2013-07-03 15:48:58 UTC) #6

*** Submitted:

Mis-aligned relation with DnD services

Dropped services were missing the 'dragged' attribute, which informs the code
the deploys them that they have been intentionally placed, and thus their x/y
coords need to be stored in annotations.  The behavior seen was a result of the
service box having .x and .y set, but not .annotations['gui-x'] and
.annotations['gui-y'].  The attribute 'dragged' is now renamed to
'hasBeenPositioned', and tests added.

R=jeff.pihach, benji
CC=
https://codereview.appspot.com/10876044

Expand All Messages | Collapse All Messages